[pull] main from github:main - #250
Merged
Merged
Conversation
…l-registration API (#2223) The Node.js example in the "CLI -> SDK (inbound)" section of docs/observability/opentelemetry.md registered a tool by calling session.registerTool(myTool, handler). That method is not part of the public CopilotSession API, so copying the example fails to compile with error TS2339: Property 'registerTool' does not exist on type 'CopilotSession' and, if the types are bypassed, throws "TypeError: session.registerTool is not a function" at runtime. The plural registerTools() is marked @internal and stripped from the shipped declarations, so there is no public session method to register a tool with after the session exists. Move the trace-restoring handler into defineTool() and register the tool through client.createSession({ tools: [myTool] }), which is the public registration path and the one used by the rest of the documentation. The trace-context logic is unchanged; only the registration mechanism is corrected. As a side effect the handler's args and invocation parameters are now contextually typed, so the invocation.traceparent / invocation.tracestate access in the example is actually type-checked. Co-authored-by: examon <examon@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )