You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Can we simplify the windows building by always using -G Ninja? #1734
If we always using ninja we can simplify the windows build and remove all the handling of different MSVC versions?
We could just mandate that if you want to build anything form source you need to run emsdk from visual sudio command prompt. (i.e. you are expected to have run vsvarsall.bat already and/or have cl.exe in PATH).
@juj do you have any reason not to use ninja for all your windows builds?
Activity
sbc100 commentedon Jul 15, 2026
Example PR for how much complexity we could remove: #1736
[windows] Always use Ninja generator when build cmake projects form s…
[docs] Document Ninja requirement when building from source
[docs] Document Ninja requirement when building from source
[docs] Document Ninja requirement when building from source
[windows] Always use Ninja generator when build cmake projects form s…
[windows] Always use Ninja generator when build cmake projects form s…
[windows] Always use Ninja generator when build cmake projects form s…
[windows] Always use Ninja generator when build cmake projects form s…
[windows] Always use Ninja generator when build cmake projects form s…
[windows] Always use Ninja generator when build cmake projects form s…
[windows] Always use Ninja generator when build cmake projects form s…