Reverting #2354 #2712

Activity

1. karpetrosyan commented on May 21, 2023

   

   karpetrosyan

   on May 21, 2023

   Last edited by karpetrosyan

   ContributorAuthor

   More actions

   There are several helpful links related to this issue.

   The initial issue that represents this problem: #2331
   The pull request that 'fixed' the #2331: #2354
2. karpetrosyan

   closed this as completedon May 21, 2023
3. karpetrosyan commented on May 21, 2023

   

   karpetrosyan

   on May 21, 2023

   ContributorAuthor

   More actions

   I had no idea why we were merging 'params' with queries passed into strings in this manner.

   >>> httpx.get('http://example.com?test', params={'test1': None}).request.url
   URL('http://example.com?test=&test1=')

   but expected

   URL('http://example.com?test&test1=')

   or

   URL('http://example.com?testtest1=')

   or even better

   URL('http://example.com?test1=')

   Params means we want an acceptable format "key=val&", but when we combine this with the string supplied into the uri, I don't believe there is a server that will recognize such a format.

   Overriding queries passed into the string if they are not in "key=value" format is much more expected behavior, in my opinion.

   For example

   >>> httpx.get('http://example.com?test', params={'test1': None}).request.uri  # overriding because query is not 'key=value' format
   URL('http://example.com?test1=')
   >>> httpx.get('http://example.com?test=value', params={'test1': None}).request.uri
   URL('http://example.com?test=value&test1=') # keep queries since they are in 'key=value' format.

   @tomchristie Please reopen this issue if you find this behavior weird, or convert it to discussion if it appears to you to be fine.
4. lovelydinosaur commented on May 22, 2023

   

   lovelydinosaur

   on May 22, 2023

   Last edited by lovelydinosaur

   Member

   More actions

   There are two different aspects you're highlighting here...

   There's "why do we merge query params, rather than replace them..." which we can narrow down a bit...

   >>> httpx.Request('GET', 'http://example.com?a=1', params={'b': '2'})
   <Request('GET', 'http://example.com?a=1&b=2')>

   I'd agree that I don't think we have the most intuitive behaviour here. I'll raise a ticket for this. (EDIT: done #2713)

   There's also "how do we handle ?a= vs ?a style empty query parameters". This is more complex but might also deserve a ticket.