Skip to content

chore: drop nodejs < 18#1020

Merged
UlisesGascon merged 6 commits into
expressjs:v2from
bjohansebas:node18+
Mar 16, 2025
Merged

chore: drop nodejs < 18#1020
UlisesGascon merged 6 commits into
expressjs:v2from
bjohansebas:node18+

Conversation

@bjohansebas

@bjohansebas bjohansebas commented Feb 10, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Support for old Node.js is removed, and the express CI is copied :)

@bjohansebas

bjohansebas commented Feb 10, 2025

Copy link
Copy Markdown
Member Author

@UlisesGascon can you bring the latest changes from the master branch to v2?

@jonchurch jonchurch changed the title chore: drop nodejs 18 chore: drop nodejs < 18 Feb 11, 2025
@jonchurch

jonchurch commented Feb 11, 2025

Copy link
Copy Markdown
Member

Ah yeah, I see it needs the commit from Chris to generate a fresh cert

@bjohansebas

bjohansebas commented Feb 11, 2025

Copy link
Copy Markdown
Member Author

Yep, only you can do it since I don't have the permissions :)

@UlisesGascon UlisesGascon mentioned this pull request Feb 12, 2025
Merged
Phillip9587
Phillip9587 reviewed Feb 13, 2025
View reviewed changes
Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/ci.yml Outdated
@Phillip9587

Phillip9587 commented Feb 13, 2025

Copy link
Copy Markdown
Member

I have just left two minor comments.

Also, I wanted to check—do we need to run the CI on windows-latest? The previous workflow only ran on ubuntu-latest. I believe our policy is that lower-level packages only run CI on Linux. Could you confirm if this change is intentional?

Let me know what you think!

@bjohansebas @Phillip9587
Update .github/workflows/ci.yml
72332eb 
Co-authored-by: Phillip Barta <barta.phillip@gmail.com>
@bjohansebas

bjohansebas commented Feb 13, 2025

Copy link
Copy Markdown
Member Author

Well, this is not a lower-level package, but I don't think we want to run tests on Windows here.

@Phillip9587

This comment has been minimized.

Sign in to view
@bjohansebas

bjohansebas commented Feb 13, 2025

Copy link
Copy Markdown
Member Author

It should have the latest changes from that branch

Phillip9587
Phillip9587 suggested changes Feb 13, 2025
View reviewed changes
Comment thread .github/workflows/ci.yml Outdated
@bjohansebas @Phillip9587
Update .github/workflows/ci.yml
be34484 
Co-authored-by: Phillip Barta <barta.phillip@gmail.com>
@wesleytodd
wesleytodd removed their request for review February 17, 2025 15:24
@bjohansebas

bjohansebas commented Mar 6, 2025

Copy link
Copy Markdown
Member Author

I would like to move forward with some changes for this package.

@bjohansebas

bjohansebas commented Mar 16, 2025

Copy link
Copy Markdown
Member Author

cc @UlisesGascon Can you merge this please, or can you make me a committer, please?

@bjohansebas

bjohansebas commented Mar 16, 2025

Copy link
Copy Markdown
Member Author

This blocked #1025 and #1023.

@UlisesGascon
UlisesGascon merged commit d3ab22c into expressjs:v2 Mar 16, 2025
@UlisesGascon UlisesGascon self-assigned this Mar 16, 2025
@bjohansebas
bjohansebas deleted the node18+ branch March 16, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@UlisesGascon UlisesGascon UlisesGascon approved these changes
@jonchurch jonchurch Awaiting requested review from jonchurch
+1 more reviewer
@Phillip9587 Phillip9587 Phillip9587 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@UlisesGascon UlisesGascon

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bjohansebas @jonchurch @Phillip9587 @UlisesGascon