Skip to content

add warning content about saving data.#393

Closed
0x11-dev wants to merge 1 commit into
expressjs:masterfrom
0x11-dev:master
Closed

add warning content about saving data.#393
0x11-dev wants to merge 1 commit into
expressjs:masterfrom
0x11-dev:master

Conversation

@0x11-dev

@0x11-dev 0x11-dev commented Dec 5, 2016

Copy link
Copy Markdown

update readme.md. add warning content about saving data.

add save warining
@0x11-dev

0x11-dev commented Dec 5, 2016

Copy link
Copy Markdown
Author

hi there, I found the solution after hours debug and read session source code. I thought It may saving others time by add the warning content. Many users ask questions on StackOverflow.com when they face the same situation. This may be worth.

@0x11-dev 0x11-dev changed the title Update README.md add warning content about saving data. Dec 5, 2016
@dougwilson

Copy link
Copy Markdown
Contributor

Thanks, but it's pretty much a duplicate of the existing docs:

This method is automatically called at the end of the HTTP response if the session data has been altered (though this behavior can be altered with various options in the middleware constructor).

@dougwilson dougwilson closed this Dec 5, 2016
@dougwilson dougwilson self-assigned this Dec 5, 2016
@0x11-dev

0x11-dev commented Dec 6, 2016

Copy link
Copy Markdown
Author

The existing docs does not address the problem out: Update session after response.send or response.end will not work. BTW, the existing docs is very elegant. Professionals will notice when they saw it, but the beginner may not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants