feat: adds optional sessionID getter #40
Conversation
|
Uhhh this kind of sounds like a terrible idea because people could just hijack other peoples sessions. If it's an API, why don't you just use auth or an api key or something? |
|
Yes @jonathanong, also in my opinion adding a getter is asking for throubles.. |
|
The idea of abstracting the way express-session gets –and sets– the sesisonID from/to the client seems like a reasonable idea, but I don't think this is the way to do it. The getting and setting of the sessionId, however its implemented, should be handled by a single module. |
|
Closing because the consensus is -1. @joewagner I agree this module needs a lot of refactoring |
Allows an alternative to only using the cookie to get the sessionID. Designed mostly for API interfaces who don't want to store cookies, and would rather use headers or query params.