Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.js
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ function session(options){
, rollingSessions = options.rolling || false;

// TODO: switch default to false on next major
var resaveSession = options.resave === undefined
var resaveSession = (options.resave === undefined || options.resave)
? true
: false;

Expand Down
29 changes: 29 additions & 0 deletions test/session.js
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,35 @@ describe('session()', function(){
})

describe('resave option', function(){
it('should allow setting to true', function(done){
var count = 0;
var app = express();
app.use(cookieParser());
app.use(session({ resave: true, secret: 'keyboard cat', cookie: { maxAge: min }}));
app.use(function(req, res, next){
var save = req.session.save;
res.setHeader('x-count', count);
req.session.user = 'bob';
req.session.save = function(fn){
res.setHeader('x-count', ++count);
return save.call(this, fn);
};
res.end();
});

request(app)
.get('/')
.expect('x-count', '1')
.expect(200, function(err, res){
if (err) return done(err);
request(app)
.get('/')
.set('Cookie', 'connect.sid=' + sid(res))
.expect('x-count', '2')
.expect(200, done);
});
});

it('should default to true', function(done){
var count = 0;
var app = express();
Expand Down