Add ignoreErrors option to harden against store fetch errors#525
Closed
walling wants to merge 1 commit into
Closed
Add ignoreErrors option to harden against store fetch errors#525walling wants to merge 1 commit into
walling wants to merge 1 commit into
Conversation
Contributor
|
Hi @walling having an |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This option allows to ignore any fetch error from the store. That means that
req.sessionwill be undefined and as stated in the readme, the application needs to be able to handle that gracefully. However it makes it possible for the application developer to decide what should happen on errors instead of just returning HTTP 500 for the request.This is something that is very useful for ourselves, since we want to ensure a high uptime for our website and funnel, even if it means we miss some session tracking in a few cases.
Let me know if you have any questions.