fix getcookie cookie fallbacks for signed vs unsigned#539
Closed
d3zza wants to merge 1 commit into
Closed
Conversation
Contributor
|
Hi @d3zza thanks for the pull request! I'm not sure I understand the underlying change and this breaks multiple existing tests. Can you help me understand what exactly the change is doing and is breaking the existing tests intentional? |
Contributor
|
Closing per request in #540 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems to me that the fallbacks for retrieving cookies for signed and unsigned cookies are implemented the wrong way around. I'm guessing that this code doesn't get executed much since these are fallbacks only triggered when cookies are not available in headers. The reason the fallbacks are necessary in my project is because I'm using express session with sockets via https://github.com/oskosk/express-socket.io-session which stores the cookies in the req.