Adds the ability to implement a different cookie signing scheme#98
Closed
NigelKibodeaux wants to merge 16 commits into
Closed
Adds the ability to implement a different cookie signing scheme#98NigelKibodeaux wants to merge 16 commits into
NigelKibodeaux wants to merge 16 commits into
Conversation
Contributor
|
Hi @NigelKibodeaux , what was the reason for closing the PR? |
they are always signed anyway
Author
|
@dougwilson I found a bug. I'll resubmit when I confirm my fix :) |
Contributor
|
Ok, though you can just update the existing PR by adding new commits on your master branch, for the future :) |
Contributor
|
@jonathanong didn't you have a lot of wip with keygrip and signing and things? |
Member
|
@Fishrock123 yup. i had a big PR but am waiting for a second opinion and stuff. I think @dougwilson said he's handling it |
Member
|
oh i think i merged it into master. there was an issue @dougwilson wanted to fix before pushing |
Contributor
|
None of that has to do with this PR, though. |
dougwilson
force-pushed
the
master
branch
2 times, most recently
from
January 28, 2024 20:24
9d2e29b to
408229e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.