feat: Promise API#78
Merged
Merged
Conversation
SimenB
changed the title
destroy, save and reload to session instance
Pull Request Test Coverage Report for Build 2062901442
💛 - Coveralls |
Member
|
what's the semversiness of this? |
Member
Author
|
I'd say this is a minor, but #77 (which this PR is based on) is major so they can be bundled together in a new release |
4 tasks
Member
|
I've landed the first one and now this conflicts :(. |
Member
Author
|
I'll rebase tonight or tomorrow 👍 |
Member
Author
|
@mcollina done! |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm run testandnpm run benchmarkand the Code of conduct
Fixes #24.
(note that this includes #77, so just review the last commit)