Skip to content

Raise requirements #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fhamborg merged 2 commits into from
Dec 19, 2023
Merged

Raise requirements #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fec8b7d
Raise torch upper bound to <2.1
t1h0 Dec 18, 2023
f44445f
Raise python upper bound to <3.12
t1h0 Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion NewsSentiment/train.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,7 @@ def _train(self, criterion, optimizer, train_data_loader, dev_data_loader):
for i_batch, sample_batched in enumerate(train_data_loader):
global_step += 1
# clear gradient accumulators
optimizer.zero_grad()
optimizer.zero_grad(set_to_none = False)
# select only relevant fields
inputs = self.select_inputs(sample_batched)
targets = sample_batched["polarity"].to(self.opt.device)
Expand Down
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ virtualenv -ppython3.8 --setuptools 45 venv
source venv/bin/activate
```

Note: We recommend Python 3.8, however we have successfully tested NewsMTSC with Python version >=3.8, <3.12.

**2. Setup NewsMTSC:**
```bash
git clone git@github.com:fhamborg/NewsMTSC.git
Expand Down
9 changes: 5 additions & 4 deletions pythoninfo.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
This step is optional if you have Python 3.8 installed (run `python --version`
in a terminal and check the version that is printed). If you don't have Python 3.8, we
recommend using Anaconda for setting up requirements because it is very easy (but any way
of installing Python 3.8 is fine). If you do not have Anaconda yet, follow their
This step is optional if you have Python >=3.8, <3.12 installed (run `python --version`
in a terminal and check the version that is printed; we recommend 3.8). If you don't
have Python (in the correct version), we recommend using Anaconda for setting up
requirements because it is very easy (but any way of installing is fine).
If you do not have Anaconda yet, follow their
[installation instructions](https://docs.anaconda.com/anaconda/install/).

After installing Anaconda, to set up a Python 3.8 environment (in case you don't have one
Expand Down
9 changes: 6 additions & 3 deletions setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ classifiers =
Operating System :: OS Independent
Programming Language :: Python :: 3
Programming Language :: Python :: 3.8
Programming Language :: Python :: 3.9
Programming Language :: Python :: 3.10
Programming Language :: Python :: 3.11
Intended Audience :: Developers
Intended Audience :: Science/Research
Topic :: Scientific/Engineering
Expand All @@ -27,7 +30,7 @@ classifiers =
package_dir =
= .
packages = find_namespace:
python_requires = ==3.8.*
python_requires = >=3.8, <3.12
# include_package_data = true
install_requires =
boto3>=1.19.7
Expand All @@ -45,8 +48,8 @@ install_requires =
spacy>=3.2
tabulate>=0.8.9
tqdm>=4.62.3
transformers>=4.17.0,<=4.24.0
torch>=1.12.0,<1.14.0
transformers>=4.17,<=4.24
torch>=1.12,<2.1

[options.packages.find]
where = .
Expand Down