Skip to content

Load encryption code and its dependencies conditionally #885

Open

Description

@blikblum

The encryption support soon landing in #820 increases pdfkit bundle size by 10%. Pdfkit is already quite big: 480Kb minified.

It's good to make the extra dependencies opt-in, so users that do not use this feature does not carries the extra code size.

This could be accomplished by using a plugin or middleware interface. Or even just as a configurable static property

Activity

  1. Rotzbua commented on Jan 6, 2019

    @Rotzbua

    I don't need the encryption function in the browser. Pdfkit is only used for data export.
    I would appreciate it if this dependency is not activated by default and saves some traffic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions