Skip to content

feat: Add gorm session store - #131

Merged
appleboy merged 2 commits into
gin-contrib:masterfrom
TJM:gorm
Mar 26, 2022
Merged

appleboy merged 2 commits into
gin-contrib:masterfrom
TJM:gorm

Conversation

@TJM

@TJM TJM commented Mar 25, 2021

Copy link
Copy Markdown
Contributor

Adds GoRM session store

@TJM

TJM commented Apr 1, 2021

Copy link
Copy Markdown
Contributor Author

The test is now failing because of the ancient version of Go. It works on 1.13 and higher (although the error on the old ones says 1.14 :-/ ... anyhow I am not sure how to make it so this specific module is only tested on 1.14 or higher, since its a sub-part. Any tips?

@bluescreen10

Copy link
Copy Markdown

Hi, I'm interested on this feature. How can I help to get this merged in?

@bluescreen10

Copy link
Copy Markdown

Hey to skip tests on versions lower than 1.13 you can add a build constraint in the test file for example:

gorm/gorm_test.go

// +build go1.13
package gorm
...

@TJM

TJM commented Mar 25, 2022

Copy link
Copy Markdown
Contributor Author

I rebased to get rid of the conflicts. I was not sure how to resolve the ones in go.sum.... that file is a mess ;) Maybe go mod tidy ? (shrug)

@bluescreen10

Copy link
Copy Markdown

go mod tidy would certainly clean things up.

@bluescreen10

Copy link
Copy Markdown

What do you think @appleboy ?

@TJM

TJM commented Mar 25, 2022

Copy link
Copy Markdown
Contributor Author

@bluescreen10 - I have a line like the following in my go.mod to use my branch...

replace github.com/gin-contrib/sessions => github.com/TJM/sessions v0.0.4-0.20210325232733-5cce4eb28169

@idc77

idc77 commented Apr 9, 2022 •

Copy link
Copy Markdown

It's simply gorm not GoRM.
go orm gorm

@TJM TJM changed the title feat: Add GoRM session store feat: Add gorm session store Apr 11, 2022
@TJM

TJM commented Apr 11, 2022

Copy link
Copy Markdown
Contributor Author

It's simply gorm not GoRM. go orm gorm

I updated the MR title, but it was already merged, so the commit message will live on ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants