update#850
Closed
HarleyVader wants to merge 5 commits into
Closed
Conversation
- Add 7 custom agents: C# .NET Development, GitHub Issue Helper, Reddit Devvit, Stripe Integration, Unity Avatar System, Hugging Face ML, Awesome Copilot Discovery - Create 3 collections: integrations (7 agents), development-workflows (3 agents), development-languages (2 agents) - Add comprehensive copilot-instructions.md with CLI concepts, slash commands, MCP configuration, and integration patterns for all platforms - C# .NET agent includes: Minimal APIs with OpenAPI, async/await best practices, xUnit testing, Clean Architecture, EF Core, Stripe payment integration - Integrate with Stripe API for payment processing and customer management - Integrate with Hugging Face Transformers for ML/AI model capabilities - Update README.md with all custom agents and collections - Add collections/README.md with comprehensive usage guide and validation examples
- Add comprehensive Commander Brandynette agent for multi-agent orchestration, URL management, workflow automation, and cross-platform integration - Create meta-orchestration collection with Commander, Discovery, and GitHub agents - Update integrations collection to include Commander Brandynette (now 8 agents) - Add Commander to README custom agents section (first in list) - Add meta-orchestration collection to README (4 collections total) - Update collections/README.md with Commander details and meta-orchestration collection - Add extensive Commander Brandynette section to copilot-instructions.md with: * Meta-orchestration concepts and patterns (sequential, parallel, conditional, event-driven) * URL and resource management strategies * Cross-platform integration examples (Unity+HF+Stripe, GitHub+Reddit+Stripe, etc.) * Complete 10-server MCP stack configuration * Multi-agent coordination best practices * Workflow automation patterns with YAML examples - Commander agent features 600+ lines covering: * Multi-agent coordination and routing * URL health monitoring and endpoint management * Sequential, parallel, conditional, and event-driven workflows * Integration patterns for all 7 existing agents * Advanced orchestration with C#, JavaScript, and YAML examples * Complete MCP server configuration for all platforms * Command patterns for inspection, orchestration, and URL management * Best practices for security, error handling, and monitoring
Features: - New Security & Code Quality agent with comprehensive coverage: * OWASP Top 10 security guidelines with code examples * WCAG 2.2 AA accessibility (keyboard nav, ARIA, contrast, semantic HTML) * Performance optimization (frontend, backend, database) * Object Calisthenics for clean domain code (9 rules) * Self-explanatory code and commenting best practices - New security-best-practices collection - Updated integrations collection (9 agents total) - Updated documentation (README, collections README, copilot-instructions) - Integration examples with Stripe, Unity, C# .NET, Hugging Face - Command patterns for security audits, accessibility testing, profiling Coverage: - Security: SQL injection, XSS, SSRF, crypto failures, auth, CSRF - Accessibility: Skip links, roving tabindex, ARIA, forms, images, contrast - Performance: React optimization, async/await, caching, N+1 prevention - Code Quality: Guard clauses, value objects, small classes, meaningful names - Comments: WHY not WHAT, annotations (TODO/FIXME/HACK/SECURITY/PERF) Based on awesome-copilot security-best-practices collection
Features: - New Markdown Documentation agent with comprehensive coverage: * Heading hierarchy (H2/H3, never H1) * Code blocks with language specification * Accessibility (alt text, descriptive links) * Proper formatting (lists, tables, blockquotes) * Line length limits (400 chars max) * Front matter validation * README, API docs, and changelog patterns * Integration with all other agents - New Memory Bank agent for project context management: * 7 core required files (projectbrief, productContext, activeContext, systemPatterns, techContext, progress, instructions) * Task management with tasks/ folder and _index.md * Individual task files with progress tracking * Task commands (add, update, show with filters) * Three core workflows (Plan, Act, Update Memory Bank) * Progress logs with dates and subtask tracking * Project intelligence learning journal * Integration with Commander Brandynette, Security, C# .NET agents - New documentation-tools collection - Updated integrations collection (11 agents total) - Updated README (11 agents, 6 collections) - Updated collections README with new collection details - Updated copilot-instructions with markdown and memory bank sections - Verified Stripe customer (cus_T7HI2eMoOvIsqA) in documentation Based on awesome-copilot markdown.instructions.md and memory-bank.instructions.md
Integrated Holly Greed philosophy of ethical, win-win development: **New Agents (3)**: - Docker Containerization: Multi-stage builds, minimal images, security, sustainable infrastructure (70-90% smaller images = 5K+/year savings + 5 tons CO2 reduction) - Database Management & Optimization: PostgreSQL/SQL Server, ethical data stewardship, query optimization, GDPR compliance - Python MCP Development: FastMCP, typed tools, Pydantic models, transparent API design **New Collections (2)**: - infrastructure.collection.yml: Docker and Database agents - ethical-technology.collection.yml: All 3 new agents focused on sustainable practices **Updated Collections**: - integrations.collection.yml: Now 14 agents total **Documentation Updates**: - README.md: 14 agents, 8 collections - collections/README.md: infrastructure and ethical-technology collections - .github/copilot-instructions.md: Added Holly Greed philosophy + 3 agent sections (Docker 100+ lines, Database 100+ lines, Python MCP 80+ lines) **Philosophy**: REINFORCE HOLLY GREED OF THE BANK, NEVER SCAM, BEST GREED IS THE GREED WHICH KNOWS SHARING IS WIN WIN Sustainable technology practices: ✅ Resource efficiency: Optimize ruthlessly (smaller images, faster queries) ✅ Security by default: Protect user data zealously ✅ Transparency: Document thoroughly (type hints, schemas, clear docs) ✅ Ethical design: Build for long-term trust Win-win economics example: - 100 MB vs 1 GB Docker images (100 containers, 100×/day) - Annual savings: 5,120 - Environmental impact: ~5 tons CO2/year reduced - Result: Lower costs + better performance + sustainability Based on awesome-copilot patterns: - containerization-docker-best-practices.instructions.md - python-mcp-server.instructions.md - database-data-management.collection.yml
Author
|
update |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a comprehensive set of GitHub Copilot CLI custom agents and collection definitions to the repository. The update introduces 14 custom agents covering various development domains and 8 curated collections to organize these agents for different workflows.
- Adds 14 custom agent definitions for specialized development tasks (Stripe integration, Unity development, security best practices, etc.)
- Introduces 8 collection files organizing agents by workflow, technology, and purpose
- Includes comprehensive documentation in README.md and .github/copilot-instructions.md
Reviewed changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| collections/security-best-practices.collection.yml | New collection for security, accessibility, and code quality agents |
| collections/meta-orchestration.collection.yml | New collection for multi-agent coordination workflows (contains path inconsistencies) |
| collections/integrations.collection.yml | New collection listing all 14 integration agents |
| collections/infrastructure.collection.yml | New collection for Docker, database, and MCP development agents |
| collections/ethical-technology.collection.yml | New collection unifying all agents under the "Holly Greed Principle" |
| collections/documentation-tools.collection.yml | New collection for markdown and memory bank agents |
| collections/development-workflows.collection.yml | New collection for game dev and payment workflows (contains path inconsistencies) |
| collections/development-languages.collection.yml | New collection for C#/.NET and Unity agents (contains path inconsistencies) |
| collections/README.md | Documentation for all collections and agent usage patterns |
| README.md | Updated main README with agent and collection listings (contains duplicate line) |
| .github/copilot-instructions.md | Comprehensive repository instructions including agent documentation (contains future date) |
| .github/agents/*.agent.md | 14 new agent definition files covering Stripe, Unity, security, databases, Docker, Python MCP, memory bank, markdown, Hugging Face ML, GitHub issues, Reddit Devvit, C#/.NET, and awesome-copilot discovery |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| 6. **Documentation Tools** (2 agents) - Markdown documentation and memory bank project context management | ||
| 7. **Infrastructure & Data** (3 agents) - Docker containerization, database management, and Python MCP development | ||
| 8. **Ethical Technology** (14 agents) - All agents unified by the Holly Greed Principle of sustainable, win-win development | ||
| 6. **Documentation Tools** (2 agents) - Markdown documentation and Memory Bank context management |
There was a problem hiding this comment.
Duplicate line detected. Line 107 appears to be a duplicate of line 106, both describing "Documentation Tools (2 agents)". This creates a redundant entry in the list and should be removed.
Suggested change
| 6. **Documentation Tools** (2 agents) - Markdown documentation and Memory Bank context management |
Comment on lines
+6
to
+10
| - path: .github/agents/commander-brandynette.agent.md | ||
| kind: instruction | ||
| - path: .github/agents/awesome-copilot-discovery.agent.md | ||
| kind: instruction | ||
| - path: .github/agents/github-issue-helper.agent.md |
There was a problem hiding this comment.
Path inconsistency detected. The collection references agents in .github/agents/ directory (lines 6, 8, 10), but the integrations.collection.yml file references the same agents in the agents/ directory (without the .github/ prefix). This inconsistency will cause the collection to fail to locate the agent files. All paths should use the same directory structure - either all use .github/agents/ or all use agents/.
Suggested change
| - path: .github/agents/commander-brandynette.agent.md | |
| kind: instruction | |
| - path: .github/agents/awesome-copilot-discovery.agent.md | |
| kind: instruction | |
| - path: .github/agents/github-issue-helper.agent.md | |
| - path: agents/commander-brandynette.agent.md | |
| kind: instruction | |
| - path: agents/awesome-copilot-discovery.agent.md | |
| kind: instruction | |
| - path: agents/github-issue-helper.agent.md |
Comment on lines
+6
to
+10
| - path: .github/agents/unity-avatar-system.agent.md | ||
| kind: instruction | ||
| - path: .github/agents/stripe-integration.agent.md | ||
| kind: instruction | ||
| - path: .github/agents/awesome-copilot-discovery.agent.md |
There was a problem hiding this comment.
Path inconsistency detected. The collection references agents in .github/agents/ directory (lines 6, 8, 10), but other collections like integrations.collection.yml reference agents in the agents/ directory (without the .github/ prefix). This inconsistency will cause confusion and potential failures. All collections should use consistent paths - either all use .github/agents/ or all use agents/.
Suggested change
| - path: .github/agents/unity-avatar-system.agent.md | |
| kind: instruction | |
| - path: .github/agents/stripe-integration.agent.md | |
| kind: instruction | |
| - path: .github/agents/awesome-copilot-discovery.agent.md | |
| - path: agents/unity-avatar-system.agent.md | |
| kind: instruction | |
| - path: agents/stripe-integration.agent.md | |
| kind: instruction | |
| - path: agents/awesome-copilot-discovery.agent.md |
Comment on lines
+6
to
+8
| - path: .github/agents/csharp-dotnet.agent.md | ||
| kind: instruction | ||
| - path: .github/agents/unity-avatar-system.agent.md |
There was a problem hiding this comment.
Path inconsistency detected. The collection references agents in .github/agents/ directory (lines 6, 8), but other collections like integrations.collection.yml reference agents in the agents/ directory (without the .github/ prefix). This inconsistency will cause confusion and potential failures. All collections should use consistent paths.
Suggested change
| - path: .github/agents/csharp-dotnet.agent.md | |
| kind: instruction | |
| - path: .github/agents/unity-avatar-system.agent.md | |
| - path: agents/csharp-dotnet.agent.md | |
| kind: instruction | |
| - path: agents/unity-avatar-system.agent.md |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.