Skip to content

Why is the OnPermissionRequest event triggered twice for the same PermissionRequestKindWrite request? #2060

Description

@wangyang1749

Except for the requestID, the request and invocation in both calls are identical.

permissionHandler := func(request copilot.PermissionRequest, invocation copilot.PermissionInvocation) (copilotrpc.PermissionDecision, error) {
		requiresWriteConfirm := requiresWriteApproval(request)
		requestID := uuid.NewString()
		if request.Kind() == copilotrpc.PermissionRequestKindWrite {
			fmt.Printf("[Permission Check] invocation: %s, Kind: %v, Request: %+v\n", invocation.SessionID, request.Kind(), request)
		}
		h.pushBridgeEvent(session.userID, session.sessionID, "permission.request", gin.H{
			"request_id":             requestID,
			"kind":                   string(request.Kind()),
			"request":                request,
			"copilot_session_id":     fmt.Sprintf("%v", invocation.SessionID),
			"requires_write_confirm": requiresWriteConfirm,
			"session_id":             strconv.FormatInt(session.sessionID, 10),
		})

		if !requiresWriteConfirm {
			decision := copilotrpc.PermissionDecisionApproveOnce{}
			h.pushBridgeEvent(session.userID, session.sessionID, "permission.decision", gin.H{
				"request_id": requestID,
				"kind":       string(request.Kind()),
				"approved":   true,
			})
			return decision, nil
		}

		....
	}
Image Image

Metadata

Metadata

Assignees

No one assigned

    Labels

    questionFurther information is requested

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions