fix(node): exclude internal events from public union#2079
Open
hogeheer499-commits wants to merge 1 commit into
Open
fix(node): exclude internal events from public union#2079hogeheer499-commits wants to merge 1 commit into
hogeheer499-commits wants to merge 1 commit into
Conversation
hogeheer499-commits
marked this pull request as ready for review
July 24, 2026 21:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the Node SDK's generated public
SessionEventdeclaration after internal event wrappers are stripped from the published package.The generator already excluded variants whose
dataschema is internal, butassistant.turn_retryandmodel.call_startmark the event wrapper itself as internal. Their interfaces were removed bystripInternal, while their names remained in the public union. This left the published declaration with unresolved references and caused event payload types to degrade for consumers usingskipLibCheck.This change filters variants when either the resolved wrapper or its data schema is internal, regenerates the TypeScript session events, and adds a regression test for the wrapper-internal/data-public case.
Fixes #2078.
Validation
npx vitest run test/*.test.ts— 243 tests passednpm run buildnpm run typechecknpm run lint— no errors (3 existing warnings)npm run format:checkdist/generated/session-events.d.tswithskipLibCheck: falsegit diff --check