Repository navigation
Expose session feature flag overrides across SDKs - #2451
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9b0b5b94-f94a-4df4-8e57-6d7ed6fe04c1
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The public API, wire serialization, defaults, documentation, and tests consistently implement the stated behavior.
Review tier: Balanced
Findings: None
What changed in this PR
Exposes host-resolved feature flags through Rust session creation and resume configuration.
Changes:
- Adds
feature_flagsfields and fluent builders. - Serializes configured flags as
featureFlagswhile omitting unset values. - Adds focused serialization tests.
| File | Description |
|---|---|
rust/src/wire.rs |
Adds optional feature flags to create and resume payloads. |
rust/src/types.rs |
Exposes, forwards, documents, and tests feature flag configuration. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Cross-SDK Consistency Review ✅This PR adds
Observations:
No consistency gaps found. The PR maintains strong cross-SDK parity. 👍
|
SteveSandersonMS
left a comment
There was a problem hiding this comment.
Reviewed the expanded six-language implementation. Create/resume forwarding, unset and explicit false semantics, Go empty-map handling, clone behavior, and language-native tests are covered. The full CI matrix passes.
Summary
featureFlagsacross the JSON-RPC boundary while omitting unset valuesfalsevalues and the distinction between an unset map and an explicitly empty mapTesting
SessionRequestBuilderTest