Skip to content

[go] Avoid duplicate bundler license downloads #2453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SteveSandersonMS merged 1 commit into from
Sep 1, 2026
Merged

[go] Avoid duplicate bundler license downloads #2453

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions go/cmd/bundler/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,10 @@ func main() {
os.Exit(1)
}
}
if err := downloadCLILicense(version, outputPath); err != nil {
fmt.Fprintf(os.Stderr, "Error: failed to download CLI license: %v\n", err)
os.Exit(1)
}

// Generate the Go file with embed directive
if err := generateGoFile(
Expand Down Expand Up @@ -321,9 +325,6 @@ func buildBundle(info platformInfo, cliVersion, outputPath, goos string) (bundle
if err != nil {
return bundleArtifacts{}, fmt.Errorf("failed to hash existing output: %w", err)
}
if err := downloadCLILicense(cliVersion, outputPath); err != nil {
return bundleArtifacts{}, fmt.Errorf("failed to download CLI license: %w", err)
}
runtimeHash, err := sha256FileFromCompressed(runtimeArtifactPath)
if err != nil {
return bundleArtifacts{}, fmt.Errorf("failed to hash existing runtime.node: %w", err)
Expand Down Expand Up @@ -364,9 +365,6 @@ func buildBundle(info platformInfo, cliVersion, outputPath, goos string) (bundle
if err := compressZstdFile(binaryPath, outputPath); err != nil {
return bundleArtifacts{}, fmt.Errorf("failed to write output binary: %w", err)
}
if err := downloadCLILicense(cliVersion, outputPath); err != nil {
return bundleArtifacts{}, fmt.Errorf("failed to download CLI license: %w", err)
}

rawLibPath := filepath.Join(tempDir, "runtime.node")
if err := extractFileFromTarball(
Expand Down
Loading