Skip to content

[lint-monster] [LintMonster] function-length refactoring backlog in pkg/workflow and pkg/cli (669 findings) #48509

Description

@github-actions

Summary

The latest make golint-custom scan reports 669 largefunc / long-function findings in the shared function-length refactoring backlog across pkg/workflow and pkg/cli. Per repository policy, this is tracked as one shared topic rather than split by package or snapshot.

Current authoritative count

  • 669 findings total
  • 419 unique files affected
  • Shared scope: pkg/workflow/** and pkg/cli/**

Representative findings:

  • pkg/workflow/awf_helpers.go: BuildAWFCommand is 377 lines
  • pkg/workflow/codex_engine.go: GetExecutionSteps is 315 lines
  • pkg/workflow/compiler_safe_outputs_job.go: buildSafeOutputsHandlerOutputsAndActionSteps is 220 lines
  • pkg/workflow/unified_prompt_step.go: generateUnifiedPromptCreationStep is 259 lines
  • pkg/cli/add_interactive_git.go: createWorkflowPRAndConfigureSecret is 171 lines
  • pkg/cli/audit_diff.go: computeFirewallDiff is 144 lines

Next slices to refactor

  • Slice 1: top-length helpers in pkg/workflow/awf_helpers.go
  • Slice 2: engine execution builders in pkg/workflow/*_engine.go
  • Slice 3: compiler safe-outputs builders in pkg/workflow/compiler_safe_outputs*
  • Slice 4: parser/frontmatter/config builders in pkg/workflow/*parser* and related config files
  • Slice 5: interactive/audit command flows in pkg/cli/*

Remediation guidance

  • Keep changes scoped to the assigned slice only.
  • Prefer minimal, targeted helper extraction instead of behavioral rewrites.
  • Preserve existing signatures unless a small internal helper meaningfully reduces length.
  • Validate with make golint-custom after the slice is complete.

Expected outcome

Reduce the shared 669-finding backlog without creating new lint findings or changing behavior.

Labels suggested: automation, code-quality, linting.

Generated by 🧌 LintMonster · gpt54 · 20.5 AIC · ⌖ 4.97 AIC · ⊞ 4.7K ·

  • expires on Aug 3, 2026, 7:41 PM UTC-08:00

Metadata

Metadata

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions