Summary
The latest make golint-custom scan reports 669 largefunc / long-function findings in the shared function-length refactoring backlog across pkg/workflow and pkg/cli. Per repository policy, this is tracked as one shared topic rather than split by package or snapshot.
Current authoritative count
- 669 findings total
- 419 unique files affected
- Shared scope:
pkg/workflow/** and pkg/cli/**
Representative findings:
pkg/workflow/awf_helpers.go: BuildAWFCommand is 377 lines
pkg/workflow/codex_engine.go: GetExecutionSteps is 315 lines
pkg/workflow/compiler_safe_outputs_job.go: buildSafeOutputsHandlerOutputsAndActionSteps is 220 lines
pkg/workflow/unified_prompt_step.go: generateUnifiedPromptCreationStep is 259 lines
pkg/cli/add_interactive_git.go: createWorkflowPRAndConfigureSecret is 171 lines
pkg/cli/audit_diff.go: computeFirewallDiff is 144 lines
Next slices to refactor
Remediation guidance
- Keep changes scoped to the assigned slice only.
- Prefer minimal, targeted helper extraction instead of behavioral rewrites.
- Preserve existing signatures unless a small internal helper meaningfully reduces length.
- Validate with
make golint-custom after the slice is complete.
Expected outcome
Reduce the shared 669-finding backlog without creating new lint findings or changing behavior.
Labels suggested: automation, code-quality, linting.
Generated by 🧌 LintMonster · gpt54 · 20.5 AIC · ⌖ 4.97 AIC · ⊞ 4.7K · ◷
Summary
The latest
make golint-customscan reports 669largefunc/ long-function findings in the sharedfunction-length refactoringbacklog acrosspkg/workflowandpkg/cli. Per repository policy, this is tracked as one shared topic rather than split by package or snapshot.Current authoritative count
pkg/workflow/**andpkg/cli/**Representative findings:
pkg/workflow/awf_helpers.go:BuildAWFCommandis 377 linespkg/workflow/codex_engine.go:GetExecutionStepsis 315 linespkg/workflow/compiler_safe_outputs_job.go:buildSafeOutputsHandlerOutputsAndActionStepsis 220 linespkg/workflow/unified_prompt_step.go:generateUnifiedPromptCreationStepis 259 linespkg/cli/add_interactive_git.go:createWorkflowPRAndConfigureSecretis 171 linespkg/cli/audit_diff.go:computeFirewallDiffis 144 linesNext slices to refactor
pkg/workflow/awf_helpers.gopkg/workflow/*_engine.gopkg/workflow/compiler_safe_outputs*pkg/workflow/*parser*and related config filespkg/cli/*Remediation guidance
make golint-customafter the slice is complete.Expected outcome
Reduce the shared 669-finding backlog without creating new lint findings or changing behavior.
Labels suggested:
automation,code-quality,linting.