You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Mermaid allow the rendering of diagrams from markdown-like text snippets. Code-highlighting could be reused to render them when setting mermaid as the languaje. This is related to #334
@piranna Can you give us a sense of how this is currently used across GitHub? Is there an extension for the file format, for example?
I've not seen anybody using it on GitHub, maybe because it's not an available functionality, nor know of any browser extensión.
On the other hand, I've seen a webservice that generate PNG images from Mermaid snippets that can be inserted on Markdown files (sorry, I can't find the link now) and a quick search has shown me other use cases, like a plugin for gitbook, a plugin for LightTable and a plugin for Jekyll (maybe you would be more interested in that last one).
This isn't quite a markup-related issue so I'm closing the issue, but we're definitely still thinking about things like this. If you have other feature requests, please reach out to the support team.
It seems to me that this is indeed related to markup?
This repo is for things relating specifically to the github-markup gem; if an issue cannot be resolved by some change to code in this repo, then it doesn't belong here (and instead belongs with the support team). I hope that helps clarify!
@localredhead That's certainly close. All one needs to do is integrate an SVG to PNG converter that can produce a url with the png encoded in base64. This seems relevant.
The correct destination is the support team! They handle feature requests for github.com.
This is still the case! github-markup does not handle rendering; it only chooses a markup library for use. If you want support for Mermaid diagrams, the correct destination is the support team. Thanks.
That's it! I already contact them to ask for this awesome feature. We hope to have support with a mermaid in GitHub. In our case is a waste of time to have to transform all our mermaid diagrams to png images and upload. It's very complicated for us.
Reacted by Asherah Connor, Ryuichi Inagaki and Carlos Yakimov
Thanks for submitting this correctly! I'll lock this thread now as +1s will only get seen by me, the markup gem maintainer, and not by the people who are responsible for feature requests. :)
Activity
gjtorikian commentedon Aug 7, 2015
I wonder if this is something @github/render would be interested in picking up? The project does look interesting.
@piranna Can you give us a sense of how this is currently used across GitHub? Is there an extension for the file format, for example?
piranna commentedon Aug 7, 2015
I've not seen anybody using it on GitHub, maybe because it's not an available functionality, nor know of any browser extensión.
On the other hand, I've seen a webservice that generate PNG images from Mermaid snippets that can be inserted on Markdown files (sorry, I can't find the link now) and a quick search has shown me other use cases, like a plugin for gitbook, a plugin for LightTable and a plugin for Jekyll (maybe you would be more interested in that last one).
alanjames1987 commentedon Sep 6, 2016
+1
trusch commentedon Feb 26, 2017
+1
kivikakk commentedon Mar 23, 2017
This isn't quite a
markup-related issue so I'm closing the issue, but we're definitely still thinking about things like this. If you have other feature requests, please reach out to the support team.wmertens commentedon Aug 11, 2017
Note, in v1.15 of VSCode they enabled extensions for the markdown previewer, and there is https://github.com/mjbvz/vscode-markdown-mermaid which renders the images inline.
wmertens commentedon Dec 1, 2017
@kivikakk So the request here was to add support for Mermaid, which would be two-fold:
.mermaidfiles```mermaidcode blocks as Mermaid. I am not sure if this is possible? Are code blocks always passed tolinguist?It seems to me that this is indeed related to
markup?kivikakk commentedon Dec 4, 2017
This repo is for things relating specifically to the
github-markupgem; if an issue cannot be resolved by some change to code in this repo, then it doesn't belong here (and instead belongs with the support team). I hope that helps clarify!themightychris commentedon Jan 5, 2018
Did an issue over get created in the appropriate place for this? It would be an amazing addition to github
wmertens commentedon Jan 5, 2018
@themightychris I think the appropriate repo is https://github.com/gjtorikian/commonmarker, not sure, no issue created yet.
kivikakk commentedon Jan 5, 2018
The correct destination is the support team! They handle feature requests for github.com.
marcussacana commentedon Feb 17, 2018
any news?
9 remaining items
trusch commentedon Jan 4, 2019
cristianvasquez commentedon Jan 18, 2019
+1
dderiso commentedon Jan 18, 2019
@localredhead That's certainly close. All one needs to do is integrate an SVG to PNG converter that can produce a url with the png encoded in base64. This seems relevant.
tom-sherman commentedon Jan 25, 2019
Would love for this to be revisited, especially since GitLab directly supports mermaid in markdown.
rkclark commentedon Jan 30, 2019
+1
shashank-sharma commentedon Feb 2, 2019
This feature can greatly increase the quality of documentation we have in GitHub ... Waiting!
matthew-cochran commentedon Feb 7, 2019
+1
John-Youngblood commentedon Feb 11, 2019
+1
rferro commentedon Feb 14, 2019
+1
dderiso commentedon Feb 14, 2019
@kivikakk Can you please re-open this? It seems to be a markup related question.
kivikakk commentedon Feb 15, 2019
This is still the case!
github-markupdoes not handle rendering; it only chooses a markup library for use. If you want support for Mermaid diagrams, the correct destination is the support team. Thanks.Yamilquery commentedon Apr 2, 2019
That's it! I already contact them to ask for this awesome feature. We hope to have support with a mermaid in GitHub. In our case is a waste of time to have to transform all our mermaid diagrams to png images and upload. It's very complicated for us.
DrCapa commentedon Apr 7, 2019
+1
kivikakk commentedon Apr 7, 2019
Thanks for submitting this correctly! I'll lock this thread now as +1s will only get seen by me, the markup gem maintainer, and not by the people who are responsible for feature requests. :)