Repository navigation
Inconsistent indentation of long log statements #1157
Description
There seems to be an inconsistency in how long log statements are indented when they break across lines. See the example below. If there's a line break, I'd expect the output to be like the first snippet.
class Test {
void test() {
logger.atInfo().atInfo().atInfo().atInfo().atInfo().atInfo().atInfo().atInfo().atInfo().atInfo()
.log(
"123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890");
logger.atInfo().atInfo().atInfo().atInfo().atInfo().atInfo().atInfo().atInfo().atInfo().atInfo()
.atInfo().log(
"123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890");
}
}
Activity
cushon commentedon Sep 11, 2024
Thanks for the report, I agree this is surprising.
There are some heuristics for formatting Flogger-style fluent log statements, and usually everything up to
.log(fits on a single line.There's a related internal bug b/112194879 where something similar happens with a long
.withCause(...)call.joca-bt commentedon Sep 12, 2024
I was trying to reproduce this with a regular dot with prefix but no luck so far, only with logs.
cushon commentedon Sep 12, 2024
I think that's expected, there's a very special case for formatting of log methods:
google-java-format/core/src/main/java/com/google/googlejavaformat/java/JavaInputAstVisitor.java
Line 1622 in 8a0e3b3