Rectangle rule indents lambdas 8 extra columns #2

Activity

1. cushon commented on May 15, 2015

   

   cushon

   on May 15, 2015

   Collaborator

   More actions

   I think that breaking before -> is a bug. Fixing that would make it a little better:

       transacter.executeWithRetries(
           session -> {
             boolean authenticated = appAuthenticator.isAuthenticated(session, appAuthorization);
             if (!authenticated) {
               logger.info("signOutApp failed for [appToken=%s]", appAuthorization.appToken);
               throw CashApiException.unauthorized();
             }
             appAuthenticator.revokeSession(session, appAuthorization.appToken, false);
           });
   
2. kevinb9n commented on May 15, 2015

   

   kevinb9n

   on May 15, 2015

   Contributor

   More actions

   Roughly, I would say:

   When a lambda is using in-line presentation, then -> is like a binary
   operator.
   When a lambda is using block presentation, then the (params) -> { part
   ought to bind more tightly together than we see here.

   On Fri, May 15, 2015 at 8:47 AM, Liam Miller-Cushon <
   notifications@github.com> wrote:

   I think that breaking before -> is a bug. Fixing that would make it a
   little better:

   transacter.executeWithRetries(
       session -> {
         boolean authenticated = appAuthenticator.isAuthenticated(session, appAuthorization);
         if (!authenticated) {
           logger.info("signOutApp failed for [appToken=%s]", appAuthorization.appToken);
           throw CashApiException.unauthorized();
         }
         appAuthenticator.revokeSession(session, appAuthorization.appToken, false);
       });
   

   —
   Reply to this email directly or view it on GitHub
   #2 (comment)
   .

   Kevin Bourrillion | Java Librarian | Google, Inc. | kevinb@google.com
3. cushon

   closed this as completedin f2670a9on Aug 6, 2015
4. trick77

   added a commit that references this issue on Jan 17, 2026

   Merge pull request #2 from MrDolch/update-from-template

   ...

   90cc30d