Provide apiEndpoint override option  #2928

Activity

1. JustinBeckwith

   self-assigned this

   on May 22, 2019
2. JustinBeckwith

   added

   type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.

   on May 22, 2019
3. stephenplusplus commented on May 22, 2019

   

   stephenplusplus

   on May 22, 2019

   Contributor

   More actions

   We used to have this in common! Did we lose it?
4. JustinBeckwith commented on May 23, 2019

   

   JustinBeckwith

   on May 23, 2019

   ContributorAuthor

   More actions

   Oh bother - I appear to have missed this one 😆 I see that we handle the customEndpoint property in the MakeAuthenticatedRequestConfig interface, but it I don't think (need to look deeper) it's actually documented in any of the jsdoc or interfaces we provide. The hand written libs that sit over nodejs-common-grpc do provide this, but kinda all handle it manually.

   The plan is different based on the type of lib, but my thinking was that in the ones that sit on nodejs-common we would do something like this:

   constructor(options: StorageOptions = {}) {
      options.apiEndpoint = options.apiEndpoint ||'www.googleapis.com';
      const config = {
        baseUrl: `https://${options.apiEndpoint}/storage/v1`,
        projectIdRequired: false,
        scopes: [
          'https://www.googleapis.com/auth/cloud-platform',
          'https://www.googleapis.com/auth/devstorage.full_control',
        ],
        packageJson: require('../../package.json'),
      };
      super(config, options);
   }

   Does this seem like a good approach?
5. stephenplusplus commented on May 23, 2019

   

   stephenplusplus

   on May 23, 2019

   Contributor

   More actions

   That looks right to me! We can talk specific implementation when PR time comes, but we might want to make sure to cover also handling them separately, like host and port.
6. JustinBeckwith commented on Jul 23, 2019

   

   JustinBeckwith

   on Jul 23, 2019

   ContributorAuthor

   More actions

   We got all of this covered 👍
7. JustinBeckwith

   closed this as completedon Jul 23, 2019