Skip to content

Your .github/scripts/close-invalid-link.cjs is broken #5826

New issue
New issue
Closed
Closed
Your .github/scripts/close-invalid-link.cjs is broken#5826
Assignees
sofisl
Labels
priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.type: processA process-related concern. May include testing, release, or the like.

Description

@jefer94
jefer94
opened on Nov 19, 2024

Please make sure you have searched for information in the following guides.

Documentation Request

Document this error properly #5824

A link to a public Github Repository or gist with a minimal reproduction.

I have:

  1. A public link
  2. A gist
  3. A minimal reproduction

What do you want?, a frontend to run the SSML having a frontend written by us?

Activity

  1. jefer94 commented on Nov 19, 2024

    @jefer94
    jefer94
    on Nov 19, 2024
    Author

    image

    I ran this validation

    It seems like whoever wrote this code thought, I am getting the markdown, and forever the line that will contain the URL is the 18, it's so wrong, that could be acceptable but if for any reason you have a bug in your code you will close that issue too, you aren't checking the error, and if you fail, you close an issue, and someone accepted that PR

    You have to know that you must read line by line until read the title, and then make something like x === "" or x.startswith('http')

    Clarifying this point, could someone reopen, or whatever, opens the issue

  2. jefer94
    changed the title [-]Document this error properly[/-] [+]Your `.github/scripts/close-invalid-link.cjs` is broken[/+] on Nov 19, 2024

  3. jefer94 commented on Nov 19, 2024

    @jefer94
    jefer94
    on Nov 19, 2024
    Author

    Add Github issue template for SSML (because this is a bug but it does require any reproduction URL)

  4. sofisl commented on Nov 20, 2024

    @sofisl
    sofisl
    on Nov 20, 2024
    Contributor

    You're completely right about this. It's an edge case and I've had trouble figuring out the best way to validate this line. Unfortunately it's not supported by current yaml. Perhaps the best way forward is just to move it up so that we always have it in a standard place (for now).

  5. jefer94 commented on Nov 20, 2024

    @jefer94
    jefer94
    on Nov 20, 2024
    Author

    I don't understand your assertions:

    1. The YML seems like a Node env, it received issue.data.body, it has a split, and it seems like a string, what's my point, Javascript support iterate an array, when you reach the same line could work, besides, you have known the next title and you could use a break when you see it in a conditional
    2. If you would want to hardcode the line of the URL, it must be the first section, so, nobody could change the line number
    3. Even if I tried to resubmit this issue, it wouldn't work because I'm providing two screenshots, I could re-submit the issue by leaving the image in another section, but:
    • It's inaccurate
    • It enforces ignore bugs and nobody is checking them
    • You could think this is the responsibility of whoever opened the issue, actually, this is a paid service, and Google must provide good services to their customers, I had a least 20% failure and I had to switch to another solution, so, you have to understand the importance of this issue, Google potentially keeps losing a client due to this policy, I thought in remove the support to Google Text to Speech in favor of another, what am I trying to say you? this is an issue with a big importance
  6. sofisl
    added
    priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.
    type: processA process-related concern. May include testing, release, or the like.
    on Nov 21, 2024
  7. sofisl
    self-assigned this
    on Nov 21, 2024

  8. jefer94 commented on Nov 22, 2024

    @jefer94
    jefer94
    on Nov 22, 2024
    Author

    Same issue:

    Hey, the policy to report issues in Google is so disgusting, it's mentally exhausting, a Google Team must be able to send reports to another Google Team, I mean, I am not a Google worker, I am forced to deal with it

    What I reported?, just see
    image

    I am frustrated, I want to never send any issue again

  9. sofisl commented on Nov 22, 2024

    @sofisl
    sofisl
    on Nov 22, 2024
    Contributor

    Hi @jefer94, as I have already described to you earlier and in #5833, you are right and I need to fix this - I haven't had time to do it this week. I have already marked this issue as a p1 and acknowledged it. However, I will be closing this one and opening another one in its stead because you are violating our code of conduct. You are right there is an issue and I will fix it - please remember there are humans behind this issue queue and we are doing our best :)

  10. sofisl
    closed this as completedon Nov 22, 2024

  11. jefer94 commented on Nov 22, 2024

    @jefer94
    jefer94
    on Nov 22, 2024
    Author

    @sofisl I am not saying that I'm frustrated about you. I'm frustrated about Google Policy, I wrote about that issue because it is related to this issue

    Addressing that I am "violating our code of conduct," I will split the mistake by each one because it seems like you are telling me that I did something related to hating someone or laughing about newbies

    About @sofisl

    • the only thing that you must do is work the stipulated work hours, I’m not saying you have to work twice to resolve our issues

    About Google

    • Google must keep the quality of its products, and respect its customers and beta testers
    • Google is responsible to be fear of they customer and the beta testers
    • Google is responsible for contract more developers if needed
    • Google is responsible for its policy and bureaucracy

    About me

    • As you @sofisl I'm working, if someone doesn't work I must leave a constancy of it
    • Maybe if I explained what happened wrong, but the error was not only a logic error, it's too don't have empathy, then I said that could be acceptable I didn't put so much importance in it, but and someone accepted that PR I'm making a strong point in that quality assurance fails

    Right now clarifying those points, @sofisl , do you think that is fear everything I had to go through? Nothing starts or ends in you, who is in charge of maintaining and enforcing the respect towards the client and beta tester? We are human beings too and we have been going through a nightmare because Google has been systematically disrespecting us

    I will leave all that happened to me, for everyone to judge if this is fair and maybe add a clause to our code of conduct about Google respecting our, because we are human beings

    #5822 (comment)
    #5823 (comment)
    #5824 (comment)
    #5833 (comment)
    https://issuetracker.google.com/issues/378688996
    https://issuetracker.google.com/issues/380282494
    https://issuetracker.google.com/issues/380295064
    googleapis/google-cloud-python#13194 (comment)
    googleapis/google-cloud-python#13102 (comment)
    googleapis/google-api-nodejs-client#3591 (comment)

    I suppose that it's fair

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.type: processA process-related concern. May include testing, release, or the like.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions