This repository was archived by the owner on Mar 3, 2026. It is now read-only.
Repository navigation
This repository was archived by the owner on Mar 3, 2026. It is now read-only.
refactor(deps)!: Remove html-entities dependency #1907
Description
Remove ent & @types/ent dependencies - they do not seem necessary given the context of its usage.
Perhaps decodeURI would work as an alternative.
Reacted by Doug Richardson and Tommi Finnilä
Activity
[-]refactor(deps): `ent` dependency[/-][+]refactor(deps): Remove `ent` dependency[/+]ddelgrosso1 commentedon Aug 2, 2022
I do not believe this to be easy to remove. The reason it is imported is that under certain situations (rate limiting if I remember correctly) the GCS API will return a response in HTML. Currently Ent is used to decode the returned HTML. I spoke with other client library owners and while they do not parse the HTML like Node does, if we were to remove this it would be a breaking change. We have two choices, close this issue as will not fix or move it until our next major release which is tentatively scheduled for Spring 2023.
[-]refactor(deps): Remove `ent` dependency[/-][+]refactor(deps)!: Remove `ent` dependency[/+]luc122c commentedon Nov 18, 2023
Hi, I think this needs revisting. ent relies on the deprecated punycode module. This is now causing issues in Node v21.x.
ddelgrosso1 commentedon Nov 19, 2023
Hi @luc122c thanks for the heads up. I will take another look and see if there is a way we can remove
entwithout causing a breaking change.drichardson commentedon Jan 11, 2024
Not sure if it's a drop in replacement, but perhaps https://www.npmjs.com/package/entities could be used to replace ent (which hasn't been updated in 9 years).
ddelgrosso1 commentedon Jan 11, 2024
@drichardson thanks for the heads up. I will poke around in entities to see if it meets our needs.
drichardson commentedon Jan 11, 2024
@ddelgrosso1 Whoops I just saw your note after making a branch using a different library called he which is pretty old and boring which seemed good for this 😄.
cfdavidpetter commentedon Apr 18, 2024
@luc122c @ddelgrosso1
I'm having trouble with this in today's latest version.
FROM node:latestddelgrosso1 commentedon Apr 18, 2024
@cfdavidpetter this issue for removing
entwhich has not been done. If you are having another issue please feel free to open a new one.cfdavidpetter commentedon Apr 18, 2024
@ddelgrosso1 my problem is this:
(node:8) [DEP0040] DeprecationWarning: Thepunycodemodule is deprecated. Please use a userland alternative instead. at node:punycode:3:9 at BuiltinModule.compileForInternalLoader (node:internal/bootstrap/realm:398:7) at BuiltinModule.compileForPublicLoader (node:internal/bootstrap/realm:337:10) at loadBuiltinModule (node:internal/modules/helpers:104:7) at Module._load (node:internal/modules/cjs/loader:999:17) at Module.require (node:internal/modules/cjs/loader:1230:19) at require (node:internal/modules/helpers:179:18) at Object.<anonymous> (/app/node_modules/whatwg-url/lib/url-state-machine.js:2:18) at Module._compile (node:internal/modules/cjs/loader:1368:14) at Module._extensions..js (node:internal/modules/cjs/loader:1426:10)ddelgrosso1 commentedon Apr 18, 2024
Thanks @cfdavidpetter we are aware of the deprecation of
punycodeand plan to removeentin the next major version of the storage library.danielbankhead commentedon Apr 27, 2024
Related:
entwithhtml-entitiesnodejs-common#813ddelgrosso1 commentedon Apr 29, 2024
Thanks @danielbankhead this is probably a good stop gap before next major version where I hope to remove the dependency altogether.
ddelgrosso1 commentedon Apr 29, 2024
#2451
ddelgrosso1 commentedon Apr 29, 2024
Enthas been replaced withhtml-entitiesfor the time being. I still intend to remove this functionality in the next major version. Going to update the title of this issue accordingly.[-]refactor(deps)!: Remove `ent` dependency[/-][+]refactor(deps)!: Remove `html-entities` dependency[/+]