Skip to content
This repository was archived by the owner on Mar 3, 2026. It is now read-only.

test: finish updating conformance test upload cases #2193

Open
Open
test: finish updating conformance test upload cases#2193
Labels
api: storageIssues related to the googleapis/nodejs-storage API.priority: p2Moderately-important priority. Fix may not be included in next release.type: processA process-related concern. May include testing, release, or the like.

Description

@tritone
tritone
opened on May 8, 2023

In #2190 I tried to add two new upload cases including 408 errors. One of them was fine, but the case "instructions": ["return-503-after-8192K", "return-408"] failed with the following error on various upload methods:

RangeError: The offset is lower than the number of bytes written. The server has 0 bytes and while 8388608 bytes has been uploaded - thus 8388608 bytes are missing. Stopping as this could result in data loss. Initiate a new upload to continue.

This looks like a bug in resetting the offset for the upload after a failure. It may be a bug in the testbench for some particular case; however, I tested manually and verified that the testbench correctly implements the method to query upload status at least for a simple case of uploading in chunks. Some debugging has to be done in the Node library to understand what is failing here.

See here for the test case to add: https://github.com/googleapis/conformance-tests/blob/main/storage/v1/retry_tests.json#L257

Activity

  1. tritone
    added
    priority: p2Moderately-important priority. Fix may not be included in next release.
    type: processA process-related concern. May include testing, release, or the like.
    on May 8, 2023
  2. product-auto-label
    added
    api: storageIssues related to the googleapis/nodejs-storage API.
    on May 8, 2023

  3. simllll commented on Apr 18, 2024

    @simllll
    simllll
    on Apr 18, 2024

    I think I ran into something simliar:

    RangeError: The offset is lower than the number of bytes written. The server has 183762944 bytes and while 184465013 bytes has been uploaded - thus 702069 bytes are missing. Stopping as this could result in data loss. Initiate a new upload to continue.
    at Upload.startUploading (/home/simon/Dev/hokify/hokify/node_modules/.pnpm/@google-cloud+storage@7.10.0/node_modules/@google-cloud/storage/build/cjs/src/resumable-upload.js:463:32)
    at Upload.continueUploading (/home/simon/Dev/hokify/hokify/node_modules/.pnpm/@google-cloud+storage@7.10.0/node_modules/@google-cloud/storage/build/cjs/src/resumable-upload.js:450:21)
    at processTicksAndRejections (node:internal/process/task_queues:95:5) RangeError

    hard to reproduce, but it happens quite a lot lately... any idea what I could try to fix this?

  4. iamstarkov commented on Aug 19, 2024

    @iamstarkov
    iamstarkov
    on Aug 19, 2024

    we experienced it during the production workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    api: storageIssues related to the googleapis/nodejs-storage API.priority: p2Moderately-important priority. Fix may not be included in next release.type: processA process-related concern. May include testing, release, or the like.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions