Skip to content
This repository was archived by the owner on Mar 3, 2026. It is now read-only.
This repository was archived by the owner on Mar 3, 2026. It is now read-only.

GetFilesResponse not fully typed #2284

Open
Open
GetFilesResponse not fully typed#2284
Labels
api: storageIssues related to the googleapis/nodejs-storage API.next major: breaking changethis is a change that we should wait to bundle into the next major versionpriority: p3Desirable enhancement or fix. May not be included in next release.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

Description

@jared-jewitt
jared-jewitt
opened on Aug 23, 2023

It would be nice to have more type definition for GetFilesResponse -- particularly for the second and third items in the tuple type.

The SDK docs don't specify that these two items exist; the only place I could find documentation about the response body (third item in the tuple) was the docs on the console.

Environment details

  • OS: MacOS Ventura 13.4.1
  • Node.js version: 16.10.0
  • npm version: 7.24.0
  • @google-cloud/storage version: 7.0.1

Steps to reproduce

  1. Observe the type definition for GetFilesResponse in node_modules
  2. Note that the second and third items in the tuple type are not fully typed

Activity

  1. jared-jewitt
    added
    priority: p2Moderately-important priority. Fix may not be included in next release.
    type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.
    on Aug 23, 2023
  2. product-auto-label
    added
    api: storageIssues related to the googleapis/nodejs-storage API.
    on Aug 23, 2023
  3. ddelgrosso1
    added
    priority: p3Desirable enhancement or fix. May not be included in next release.
    type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.
    and removed
    type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.
    priority: p2Moderately-important priority. Fix may not be included in next release.
    on Aug 24, 2023

  4. ddelgrosso1 commented on Aug 24, 2023

    @ddelgrosso1
    ddelgrosso1
    on Aug 24, 2023
    Contributor

    Hi @jared-jewitt thanks for opening an issue. We are in the process of trying to cleanup a lot of these interfaces that weren't originally typed well / typed at all. Unfortunately, since more strongly typing things is potentially a breaking change this is something we will likely have to wait to release until the next major version.

  5. ddelgrosso1
    added
    next major: breaking changethis is a change that we should wait to bundle into the next major version
    on Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    api: storageIssues related to the googleapis/nodejs-storage API.next major: breaking changethis is a change that we should wait to bundle into the next major versionpriority: p3Desirable enhancement or fix. May not be included in next release.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions