Skip to content

Missing go.sum? #183

Closed
Closed

Description

@ciehanski

It appears this package is using the now recommended go modules, but has failed to include the go.sum file which is recommended to be checked into version control.

From https://github.com/golang/go/wiki/Modules#releasing-modules-all-versions:

Ensure your go.sum file is committed along with your go.mod file. See FAQ below for more details and rationale.

Just bringing this to attention.

EDIT: browsing through most of the gorilla repositories, and this seems to be a recurring theme.

Activity

  1. stale commented on Mar 7, 2019

    @stale

    This issue has been automatically marked as stale because it hasn't seen a recent update. It'll be automatically closed in a few days.

  2. added a commit that references this issue on Apr 9, 2019
    246225a
  3. elithrar commented on Jul 23, 2019

    @elithrar
    Contributor

    FYI, for context: go.sum was not generated at the time we started to use Modules. Most repos have added & committed it since.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions