fix: prevent nil pointer dereference when store.New returns an error - #299
Closed
AdamMagued wants to merge 1 commit into
Closed
AdamMagued wants to merge 1 commit into
AdamMagued wants to merge 1 commit into
Conversation
When a custom Store implementation encounters an error in New and returns a nil Session alongside the error, Registry.Get attempted to dereference session.name without checking if session was nil, leading to a panic. Check if session is nil after store.New and return (nil, err) directly to prevent panics and avoid storing a nil session in the registry. Fixes gorilla#288
Author
|
Closing in favor of earlier community PRs to keep the review queue clean. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #288
Problem
When a custom Store implementation returns an error and a nil *Session from New(r, name), Registry.Get attempts to dereference session.name, causing a runtime nil pointer dereference panic.
Solution