Repository navigation
Conversation
…s the error (as demonstated here: http://stackoverflow.com/a/21866122/1058612). Also made some minor grammar fixes, and updated docs so that they fit within the 80 character margin (as most of the doc does).
Contributor
There was a problem hiding this comment.
This should be the other way around: we should always check the error in example code and remove the 'we're ignoring...' text from the comment.
Author
There was a problem hiding this comment.
That makes sense. The text has been reverted/updated.
Contributor
|
Thanks for the PR. Have added a couple of comments and have updated my SO answer (the one you linked to) to explicitly check the error. Example code should always check for errors as we need to set a good example of newcomers to the language. |
…ting `map[string]interface{}` text as suggested.
Author
|
Updated per comments. |
Contributor
|
Thanks again for this @dlochrie — forgot I hadn't merged this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…s the error (as demonstated here). Also made some minor grammar fixes, and updated docs so that they fit within the 80 character margin (as most of the doc does).