Skip to content

libpam-tmpdir breaks grml-debootstrap #232

Closed
#295
Closed
libpam-tmpdir breaks grml-debootstrap#232
#295

Description

@adrelanos
adrelanos
opened on Nov 8, 2023

https://packages.debian.org/bookworm/libpam-tmpdir installed on the host operating system breaks grml-debootstrap.

+ chroot /mnt/derivative-maker-grml-debootstrap.10940 dpkg --list grub-pc
+ echo 'Notice: grub-pc package not present yet, installing it therefore.'
Notice: grub-pc package not present yet, installing it therefore.
+ DEBIAN_FRONTEND=noninteractive
+ chroot /mnt/derivative-maker-grml-debootstrap.10940 apt-get -y --no-install-recommends install -o Acquire::http::Proxy=http://127.0.0.1:3142 -o Acquire::https::Proxy=http://127.0.0.1:3142 -o Acquire::tor::Proxy=http://127.0.0.1:3142 -o APT::Update::Error-Mode=any -o Acquire::Languages=none -o Acquire::IndexTargets::deb::Contents-deb::DefaultEnabled=false -o Apt::Install-Recommends=false -o Acquire::Retries=5 -o Dpkg::Options::=--force-confnew grub-pc
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
The following additional packages will be installed:
  dmsetup gettext-base grub-common grub-pc-bin grub2-common libbrotli1 libdevmapper1.02.1 libefiboot1 libefivar1 libfreetype6 libfuse2 libpng16-16 sensible-utils ucf
Suggested packages:
  multiboot-doc grub-emu mtools xorriso desktop-base console-setup fuse
Recommended packages:
  os-prober
The following NEW packages will be installed:
  dmsetup gettext-base grub-common grub-pc grub-pc-bin grub2-common libbrotli1 libdevmapper1.02.1 libefiboot1 libefivar1 libfreetype6 libfuse2 libpng16-16 sensible-utils
  ucf
0 upgraded, 15 newly installed, 0 to remove and 0 not upgraded.
Need to get 6068 kB of archives.
After this operation, 27.8 MB of additional disk space will be used.
...
Setting up grub-pc (2.06-13+deb12u1) ...
mktemp: failed to create file via template '/tmp/user/0/grub.XXXXXXXXXX': No such file or directory
dpkg: error processing package grub-pc (--configure):
 installed grub-pc package post-installation script subprocess returned error exit status 1
Processing triggers for libc-bin (2.36-9+deb12u3) ...
Errors were encountered while processing:
 grub-pc
E: Sub-process /usr/bin/dpkg returned an error code (1)

Running:

    chroot "${MNTPOINT}" mkdir --parents /tmp/user/0/

before:

    if ! chroot "${MNTPOINT}" dpkg --list grub-pc 2>/dev/null | grep -q '^ii' ; then
      echo "Notice: grub-pc package not present yet, installing it therefore."
      # shellcheck disable=SC2086
      DEBIAN_FRONTEND=$DEBIAN_FRONTEND chroot "$MNTPOINT" apt-get -y --no-install-recommends install $DPKG_OPTIONS grub-pc
    fi

Fixes this.

For the purpose of a PR to fix this:
Can I add this mkdir unconditionally or should this only be done conditionally if using libpam-tmpdir (in that case environment variables TMP, TEMP and TMPDIR will be set accordingly already).

I will also investigate alternative solutions. 1 comes to mind. Maybe installing libpam-tmpdir inside the chroot would prevent this too. Will test.

Activity

  1. adrelanos commented on Nov 8, 2023

    @adrelanos
    adrelanos
    on Nov 8, 2023
    ContributorAuthor

    Maybe installing libpam-tmpdir inside the chroot would prevent this too. Will test.

    Yes. Using grml-debootstrap with --include=...,libpam-tmpdir also fixed the issue for me.

    Good enough for me but maybe you also want a general bugfix for everyone.

  2. adrelanos commented on Nov 8, 2023

    @adrelanos
    adrelanos
    on Nov 8, 2023
    ContributorAuthor

    Yes. Using grml-debootstrap with --include=...,libpam-tmpdir also fixed the issue for me.

    Unfortunately, this is insufficient. Later on, dracut installation is failing.

    + echo 'Generating initrd.'
Generating initrd.
+ '[' dracut = dracut ']'
+ DEBIAN_FRONTEND=noninteractive
+ apt-get -y --no-install-recommends install -o Acquire::http::Proxy=http://127.0.0.1:3142 -o Acquire::https::Proxy=http://127.0.0.1:3142 -o Acquire::tor::Proxy=http://127.0.0.1:3142 -o APT::Update::Error-Mode=any -o Acquire::Languages=none -o Acquire::IndexTargets::deb::Contents-deb::DefaultEnabled=false -o Apt::Install-Recommends=false -o Acquire::Retries=5 -o Dpkg::Options::=--force-confnew dracut
Reading package lists... Done
...
Processing triggers for dracut (059-4) ...
dracut: Generating /boot/initrd.img-6.1.0-13-amd64
realpath: /tmp/user/0: No such file or directory
dracut: Invalid tmpdir '/tmp/user/0'.
dpkg: error processing package dracut (--configure):
 installed dracut package post-installation script subprocess returned error exit status 1
Errors were encountered while processing:
 dracut
E: Sub-process /usr/bin/dpkg returned an error code (1)
++ error_handler

  3. adrelanos commented on Nov 8, 2023

    @adrelanos
    adrelanos
    on Nov 8, 2023
    ContributorAuthor

    Added to function preparechroot:

    mkdir --parents "${MNTPOINT}/${TMPDIR}"

    That helped a bit but still having dracut issues.

    dracut-install: ERROR: installing 'poweroff'
dracut-install: ERROR: installing 'reboot'
dracut-install: ERROR: installing 'halt'
dracut: FAILED: /usr/lib/dracut/dracut-install -D /tmp/user/0/dracut.Yir3ea/initramfs -a umount poweroff reboot halt losetup stat sleep timeout
+ dracut --no-hostonly --kver 6.1.0-13-amd64 --fstab --add-fstab /etc/fstab --force --reproducible

  4. adrelanos commented on Nov 8, 2023

    @adrelanos
    adrelanos
    on Nov 8, 2023
    ContributorAuthor

    Even a workaround prepending:

         sudo env --unset TMPDIR --unset TMP --unset TEMPDIR  --unset TEMP grml-debootstrap ...

    does not help.

  5. adrelanos commented on Nov 8, 2023

    @adrelanos
    adrelanos
    on Nov 8, 2023
    ContributorAuthor

    Added to function preparechroot:

    mkdir --parents "${MNTPOINT}/${TMPDIR}"

    That helped a bit but still having dracut issues.

    dracut-install: ERROR: installing 'poweroff'
dracut-install: ERROR: installing 'reboot'
dracut-install: ERROR: installing 'halt'
dracut: FAILED: /usr/lib/dracut/dracut-install -D /tmp/user/0/dracut.Yir3ea/initramfs -a umount poweroff reboot halt losetup stat sleep timeout
+ dracut --no-hostonly --kver 6.1.0-13-amd64 --fstab --add-fstab /etc/fstab --force --reproducible

    That is actually a different issue:

  6. adrelanos commented on Nov 8, 2023

    @adrelanos
    adrelanos
    on Nov 8, 2023
    ContributorAuthor

    I managed to fix grml-debootstrap comparability with libpam-tmpdir. 3 changes were required.

    Now works for me. Image is bootable.

  7. adrelanos commented on Dec 8, 2023

    @adrelanos
    adrelanos
    on Dec 8, 2023
    ContributorAuthor

    TODO, in short: implement clean_chroot() { env -i chroot "$@" }

    as previously discussed in #234

    @zeha

    Instead of $chroot, we could have sth like clean_chroot() { env -i chroot "$@" } (?)

    @adrelanos

    Since @mika liked the post, seems to agree with it (and I personally don't need the environment variable), I am happy to and will attempt to implement this at a later time when other PR is ready and merged to avoid merge conflicts.

  8. adrelanos
    added 2 commits that reference this issue on Dec 23, 2023

    implement clean_chroot,

    975f14b

    implement clean_chroot,

    221a31b
  9. mika
    added a commit that references this issue on Aug 14, 2024

    Implement clean_chroot to avoid host env variables like TMP to leak i…

    07a5fe6
  10. mika
    added 3 commits that reference this issue on Nov 22, 2024

    Implement clean_chroot to avoid host env variables like TMP to leak i…

    c2d5520

    Implement clean_chroot to avoid host env variables like TMP to leak i…

    42dc98b

    Implement clean_chroot to avoid host env variables like TMP to leak i…

    be5c2e8
  11. mika
    closed this as completedin #295on Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions