You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
GitHub Pages is now using v232 of the GitHub Pages Ruby Gem. You are using v231. Please refer to the ghpages-docker Wiki for instructions on how to update.
Hi @roslynwythe
I just commented because it looks like it wouldn't take too long to resolve (I hope). I think it's better that you did this if you're willing. I had a small part when Eric worked on the code to create the docker image, so I'm somewhat familiar with it. I'd be good if more people become familiar with it.
I guess the instructions on updating the gem by clicking the "Run workflow" button to trigger the workflow-dispatch won't work for this case because the gem now depends on a much newer ruby and that requires updating the code to rebuild the image.
I don't think I have write access to that repo, but if you create a PR that needs review, I can maybe ask for temporary permission? It feels like at least the website team leads should get write access to it.
@roslynwythe that sounds right to me according to the update documentation. The gem should be automatically updated when the image is rebuilt. The only thing that needs doing seems to be updating the ruby images in the Dockerfile.
Activity
fyliu commentedon Aug 14, 2024
I see #141 saying the gem is at v227 now. Did someone rebuild the image recently?
Would anyone mind if I clicked the button to see if it updates it like the instructions say?
I'll add a note and leave this alone if it takes much more than that, but I doubt it.
Update: it's definitely on pre-v229 if the ruby version is 2.7 . Here's the v229 changes where the ruby version went from 2.7.3 to 3.3
danielridgebot commentedon Aug 15, 2024
I'm not sure what you mean by
I don't know how the ops team works but would you or someone else be interested in working on these issues? If not, I would be willing to self-assign follow the instructions in https://github.com/hackforla/ghpages-docker/wiki#how-do-you-update-ghpages-docker (in my fork) then create a PR?
fyliu commentedon Aug 16, 2024
Hi @roslynwythe
I just commented because it looks like it wouldn't take too long to resolve (I hope). I think it's better that you did this if you're willing. I had a small part when Eric worked on the code to create the docker image, so I'm somewhat familiar with it. I'd be good if more people become familiar with it.
I guess the instructions on updating the gem by clicking the "Run workflow" button to trigger the
workflow-dispatchwon't work for this case because the gem now depends on a much newer ruby and that requires updating the code to rebuild the image.I don't think I have write access to that repo, but if you create a PR that needs review, I can maybe ask for temporary permission? It feels like at least the website team leads should get write access to it.
danielridgebot commentedon Aug 19, 2024
fyliu commentedon Aug 19, 2024
@roslynwythe that sounds right to me according to the update documentation. The gem should be automatically updated when the image is rebuilt. The only thing that needs doing seems to be updating the ruby images in the Dockerfile.