Repository navigation
Mark Data.Text.Internal as Safe Haskell #539
Description
I think you might have a different interpretation of "Module encapsulation" than the intended one. Safe Haskell only promises that the semantics of abstraction are respected, it doesn't promise that you can't see the representation of a datatype by importing it from some other module.
So I don't see a reason for Data.Text.Internal to not be marked as Trustworthy module. E.g. containers Data.Set.Internal is trustworthy. And I'd expect that libraries bundles with GHC do the Safe Haskell stuff the same (and right) way if they have any Safe Haskell annotations at all.
Activity
[-]Mark Data.Text.Internal as Safe Haskell.[/-][+]Mark Data.Text.Internal as Safe Haskell[/+]Bodigrim commentedon Oct 19, 2023
Sorry, in my view Safe Haskell has negative utility, and I'm not looking forward to increase future maintenance burden by marking
Data.Text.Internalas "safe", even if according to some definition at the moment it is.(Is there was a way to opt out of Safe-Inferred without explicitly marking as Unsafe?)
phadej commentedon Oct 20, 2023
Fix haddock to say None (i.e. inferred unsafe), as it did in https://hackage.haskell.org/package/text-1.2.3.0/docs/Data-Text-Internal.html. https://gitlab.haskell.org/ghc/ghc/-/issues/19604
phadej commentedon Nov 28, 2023
To clarify, the haddock showin
Safe-inferredis a bug, and gives completely wrong impression:The
Data.Tet.Internalcannot be safely imported, it's unsafe. And IMHO it would be better to explicitly mark it asUnsafefor time being, until haddock bug is fixed (or Safe Haskell is removed from GHC, whichever happens first).