absolute paths in currentdir (conditionmanager) #178

Activity

1. sivogel

   added

   conditions

   on Jan 14, 2026
2. tyralla commented on Jan 20, 2026

   

   tyralla

   on Jan 20, 2026

   Member

   More actions

   I am unsure about the desired behaviour. I think controlcheck currently only works for the standard project directory structure.

   Maybe we could support two different signatures:

   @overload
   def controlcheck(
       controldirname: str = "default",   # minor breaking change
       projectdir: str | None = None,
       controlfile: str | None = None,
       firstdate: timetools.DateConstrArg | None = None,
       stepsize: timetools.PeriodConstrArg | None = None,
   ) -> None:
   
   @overload
   def controlcheck(
       controldirpath: str,
       controlfile: str | None = None,
       firstdate: timetools.DateConstrArg | None = None,
       stepsize: timetools.PeriodConstrArg | None = None,
   ) -> None:

   Model.save_conditions could then use the first version if pub.controlmanager.currentdir is a simple directory name or a complete path that points to the "normal" location of condition files. And it could use the second version if pub.controlmanager.currentdir is a full path pointing to a "special" location.

   There are likely cases where this heuristic would not yield the desired results. Users may sometimes be unsure if and how they will move directories later. So, we should probably also add something like an omit_controlcheck option to Model.save_conditions and HydPy.save_conditions.

   Any objections?
3. tyralla

   added

   project configuration

   improvement

   on Jan 20, 2026