Skip to content

uninstall.sh: the credential error message never shows because of set -e #132

Open

Description

@royosherove

uninstall.sh L52-53:

sts_output=$(aws sts get-caller-identity 2>&1)
sts_rc=$?

Problem: The script uses set -euo pipefail (L7). When credentials are missing or expired, the assignment fails and the script stops at once with exit 1. The lines that show sts_output and the "Run 'aws configure' first" hint never run, so the user sees no message.

Fix:

local sts_output sts_rc=0
sts_output=$(aws sts get-caller-identity 2>&1) || sts_rc=$?

Found by a code read at commit 1e50295. The code was read, but not run on a real instance.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingcrew: in progressIssue Radar work claimed by a Kiro Crew workergood first issueGood for newcomers

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions