You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
uninstall.sh: prints 'Deleted bucket' after a failed bucket delete #133
aws s3 rb "s3://${b}" --force --region "$SCAN_REGION"2>/dev/null || warn "Could not delete ${b}"
ok "Deleted bucket: ${b}"
Problem:ok always runs. If the delete fails (for example AccessDenied), the user sees "Could not delete X" and then "Deleted bucket: X" for the same bucket.
Fix:
if aws s3 rb "s3://${b}" --force --region "$SCAN_REGION"2>/dev/null;then
ok "Deleted bucket: ${b}"else
warn "Could not delete ${b}"fi
Found by a code read at commit 1e50295. The code was read, but not run on a real instance.
Activity