Skip to content

install.sh: Escape in the 'Deployment method' menu stops the installer #135

Open

Description

@royosherove

install.sh L2027-2029:

_gum_or_die method_choice $GUM choose --header "Deployment method" --selected "CloudFormation CLI" \
  "CloudFormation CLI" \
  "CloudFormation Console"

Problem: _gum_or_die returns the gum exit code (L1141), which is not zero when the user pushes Escape. The other _gum_or_die calls in the file end with || var=default, but this call does not. Under set -e, Escape stops the installer with an error. The *) default in the case below (L2033) can never run.

Fix: Add || method_choice="CloudFormation CLI" at the end of the command.


Found by a code read at commit 1e50295. The code was read, but not run on a real instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinggood first issueGood for newcomers

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions