You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If I use directly logEvent passing analytics app instance, my IDE throw this:
TS2769: No overload matches this call.
The last overload gave the following error.
Argument of type "screen_view" is not assignable to parameter of type
"add_to_cart" | "add_to_wishlist" | "remove_from_cart"
index.d.ts(422, 25): The last overload is declared here.
All screens are logged as "UIViewController" for iOS or "MainActivity" for Android and not my screen names provided! so for now I'm sticking with logScreenView and accepting the warning.
Hi there, thanks for further clarification, so simply, the screen names are not logged properly when using the modular reference as opposed to namespaced (which does show the correct names of all of your screens)?
just another coment here to prevent the bot from marking the issue as stale. The PR still exists and the issue will just get bigger with every project migrating the wrong way
Reacted by Francisco García, Jack Woodmansey, Andrew Ward, Sean Ryan, survivorsam, udany, Fadi Al-Jabi, Samuel J T, Ken Matusda, Wybe and 5 more
Reacted by Christoph, udany, Ken Matusda and trungledangAxonActive
Hello 👋, to help manage issues we automatically close stale issues.
This issue has been automatically marked as stale because it has not had activity for quite some time.Has this issue been fixed, or does it still require attention?
This issue will be closed in 15 days if no further activity occurs.
Reacted by Francisco García, Jack Woodmansey, Tim Petersen, Freddy Harris, Fadi Al-Jabi, devoren, Roman Slobodyanyuk, Christoph, Ashutosh Khanduala and ishiharas
@ashuvssut I detailed and made the necessary changes in this PR: github.com//pull/8687 maybe consider also posting there so that it is finally merged. it's important that you do NOT put the firebase_ fields into the payload or firebase will ignore your events because they are malformed.
it's important that you do NOT put the firebase_ fields into the payload or firebase will ignore your events because they are malformed.
Thanks for this clarification.
Regarding your PR, thanks for pointing it out. I’ve subscribed to it. Maintainer resources seem limited, hope it gets reviewed soon
@russellwheatley Is this issue fixed by PR #8651? If so, does this mean that there is no need for this PR #8687 anymore and the fixes would be avaible in the upcoming release?
Activity
[-][🐛] Bug Report Title - CHANGE ME[/-][+][🐛] logEvent versus logScreenView[/+]goltra commentedon Jul 14, 2025
If I use directly logEvent passing analytics app instance, my IDE throw this:
TS2769: No overload matches this call.
The last overload gave the following error.
Argument of type "screen_view" is not assignable to parameter of type
"add_to_cart" | "add_to_wishlist" | "remove_from_cart"
index.d.ts(422, 25): The last overload is declared here.
I don't know if it could be relationated.
MichaelVerdon commentedon Jul 14, 2025
Hi there, I am not sure what your issue is, could you please rephrase it? Are you saying that using Modular API does not work?
goltra commentedon Jul 14, 2025
Firstly my function was like this and work but I have a warning in console inviting me to use Modular api:
I have change for this:
but my IDE (phpstorm) show a warning
If I launch the app, it works, but it's quite confusing and makes you doubt if you're doing it correctly
goltra commentedon Jul 14, 2025
sorry, I have seen my mistake. I have to pass firebase_screen and firebase_screen_class instead of screen_name and screen_class
faljabi commentedon Jul 14, 2025
Hi @MichaelVerdon, the issue is that when using logScreenView I can see my screens names correctly on the firebase dashboard, but when using
All screens are logged as "UIViewController" for iOS or "MainActivity" for Android and not my screen names provided! so for now I'm sticking with logScreenView and accepting the warning.
MichaelVerdon commentedon Jul 14, 2025
Hi there, thanks for further clarification, so simply, the screen names are not logged properly when using the modular reference as opposed to namespaced (which does show the correct names of all of your screens)?
36 remaining items
GoodSir42 commentedon Oct 7, 2025
The issue is still not stale, because there is a pr fixing it
GoodSir42 commentedon Oct 22, 2025
just another coment here to prevent the bot from marking the issue as stale. The PR still exists and the issue will just get bigger with every project migrating the wrong way
github-actions commentedon Nov 19, 2025
Hello 👋, to help manage issues we automatically close stale issues.
This issue has been automatically marked as stale because it has not had activity for quite some time.Has this issue been fixed, or does it still require attention?
Thank you for your contributions.
GoodSir42 commentedon Nov 19, 2025
Nope, still active for the same reasons as before
faljabi commentedon Dec 11, 2025
Any update?
ashuvssut commentedon Dec 14, 2025
GoodSir42 commentedon Dec 15, 2025
@ashuvssut I detailed and made the necessary changes in this PR: github.com//pull/8687 maybe consider also posting there so that it is finally merged. it's important that you do NOT put the
firebase_fields into the payload or firebase will ignore your events because they are malformed.ashuvssut commentedon Dec 15, 2025
Thanks for this clarification.
Regarding your PR, thanks for pointing it out. I’ve subscribed to it. Maintainer resources seem limited, hope it gets reviewed soon
ashuvssut commentedon Dec 19, 2025
@russellwheatley Is this issue fixed by PR #8651? If so, does this mean that there is no need for this PR #8687 anymore and the fixes would be avaible in the upcoming release?
russellwheatley commentedon Dec 23, 2025
Yes, that is correct. See the type-test file for confirmation: https://github.com/invertase/react-native-firebase/blob/main/packages/analytics/type-test.ts#L718-L723