Repository navigation
[v4.6.0] bug: Overlay .create() changed from optional options to mandatory breaking build #18631
Description
Bug Report
Ionic version:
[x] 4.x
Current behavior:
Any OverlayController instance created using default .create() with no options passed now will not compile.
Expected behavior:
Can create OverlayController instances with no options passed in
Related code:
const loading = await this.loadingCtrl.create() //does not work now
Other information:
Change introduced in this commit:
b40f7d3#diff-75f0eda4e2b7a5b00b444247a88a3232
Activity
[-]Overlay .create() changed from optional options to mandatory breaking build[/-][+]bug: Overlay .create() changed from optional options to mandatory breaking build[/+][-]bug: Overlay .create() changed from optional options to mandatory breaking build[/-][+][v4.6.0] bug: Overlay .create() changed from optional options to mandatory breaking build[/+]liamdebeasi commentedon Jun 27, 2019
Thanks for the issue!
We are currently investigating this change. While we do that, would you be able to provide the output of running
ionic infofrom your project's directory?Thanks!
JeramieHallyburton commentedon Jun 27, 2019
Ionic:
Ionic CLI : 5.1.0 (C:\Users\jeram\AppData\Roaming\npm\node_modules\ionic)
Ionic Framework : @ionic/angular 4.6.0
@angular-devkit/build-angular : 0.800.4
@angular-devkit/schematics : 8.0.4
@angular/cli : 8.0.4
@ionic/angular-toolkit : 1.5.1
Cordova:
Cordova CLI : 8.0.0
Cordova Platforms : none
Cordova Plugins : cordova-plugin-ionic-keyboard 2.1.3, (and 4 other plugins)
Utility:
cordova-res : not installed
native-run : not installed
System:
Android SDK Tools : 26.1.1 (C:\Program Files (x86)\Android\android-sdk)
NodeJS : v10.13.0 (C:\Program Files\nodejs\node.exe)
npm : 6.4.1
OS : Windows 10
brandyscarney commentedon Jul 1, 2019
Thanks for the issue! I am going to close this as it has been fixed in Ionic, it will be in the 4.6.1 hotfix release. Please follow #18655 for updates on this. 🙂
ionitron-bot commentedon Jul 31, 2019
Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.