Repository navigation
Make refresher & infinite-scroll use attributes on element #720
Description
Changes this:
<ion-content on-infinite-scroll="getMoreData()" on-refresh-complete="getMoreData()">
<ion-refresher ng-if="canRefresh()"></ion-refresher>
<ion-infinite-scroll ng-if="hasMoreData()"></ion-infinite-scroll>
</ion-content>To this (attribute names wip):
<ion-content>
<ion-refresher ng-if="canRefresh()" on-complete="refreshData()"></ion-refresher>
<ion-infinite-scroll ng-if="hasMoreData()" on-infinite="getMoreData()"></ion-infinite-scroll>
</ion-content>- We can deprecate the attributes on ionContent but still have them work for a few versions
- Takes some attributes off of ionContent and puts them where they make sense to be.
- Will be easy to do once we have documentation in.
Metadata
Metadata
Assignees
Labels
No labels
Activity
ajoslin commentedon Mar 4, 2014
Related: #711, #692, #661
deflomu commentedon Mar 5, 2014
I see you have added some code here 3715bfc. Just two things I noticed: The documentation for ion-infinite-scroll says the attribute is called on-scroll but it's actually called on-infinite. And a second thing: Why leave deprecated stuff in there? You didn't even release a first version so while still in development just delete deprecated stuff. This only makes the code less maintainable.
ajoslin commentedon Mar 5, 2014
Yeah I saw the docs thing and fixed it but didn't commit quite yet.
I'm going to leave the deprecation in there until 1.0 probably, since it would break quite a few apps. True, we are in alpha, but if it's easy to support the old we should leave it working for now. This leaves the code only a tiny bit less maintainable.
We're hoping to get automatically generated documentation out this week before the 1.0-beta1 release - working on it now. Then I think it would be good to remove the deprecated option in 1.0-beta2.
ajoslin commentedon Mar 12, 2014
Closed via 573df56
ionitron-bot commentedon Sep 6, 2018
Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.