Repository navigation
tag (label) pull requests #1
Description
The API seems to support tagging pull requests, but it's not surfaced in the UI.
As a maintainer of a few repos that get a ton of pull requests, it would be incredibly helpful to be able to tag pull requests to sort and select them based on arbitrary overlapping semantics, such as the area of the program that they touch, whether they are a bugfix or new feature, whether we're awaiting the user signing a CLA, etc.
Milestones and assignment are great as well, however, they do not address quite the same use cases. Milestones are for organizing release trains (and super helpful!), and assignment is for indicating that a user is responsible for a pull req (also super helpeful!), but this is more about arbitrary overlapping categories, which tags are perfect for.
Activity
dreww commentedon Jun 4, 2013
there is exactly one place in the UI where you can label a pull request.
perhaps unintuitively, it is on the Issues page:
hope this helps.
isaacs commentedon Jun 4, 2013
@dreww That's fantastic! I'm going to start using this!
However, I think that the fact that I've literally been searching for this for months, and constantly complaining about it to every githubber I come into contact with, and I'm just now finding out about it, indicates that it should really be exposed more effectively.
Also, because it is not exposed on the /pulls our /pulls/id page, it makes it much less useful than it could be, and rather klunky to get to. When I'm reviewing pull reqs for a specific milestone, I then have to go back and find the pull req in the issues list, etc. Not a smooth userflow at all.
isaacs commentedon Jun 4, 2013
@tjfontaine had a great idea to take advantage of this: We can have a bot label all pull requests with "pr" and the target branch, so we can filter that way.
luka8088 commentedon Jul 31, 2013
Hi! I tried injecting html code for labels (
<div class="discussion-labels">...</div>) into a pull request and it works. Not only that it show but it allows correct label changing. Are labels removed from pull requests on purpose? Because this is very useful and looks easily implementable.snopoke commentedon Aug 27, 2013
This would be super handy to have access to when creating and viewing PR's. Even once I've labeled the issue related to a PR I don't see the label when viewing the list of PR's or even when viewing the PR itself so unless I go to the issues list I won't even know that it has a label.
kiori commentedon Nov 14, 2013
this looks it hasn't happened yet?
iguananaut commentedon Nov 30, 2013
Shameless self-promotion here, but I've added a working Greasemonkey script to add support for this: http://userscripts.org/scripts/show/185095
It was easy enough to do that it still mystifies me that GitHub doesn't do this...
patcon commentedon Dec 2, 2013
Nice! 👍
EDIT: I just installed, but doesn't seem to be working. I openned a PR: iguananaut/userscripts#3
snopoke commentedon Dec 2, 2013
That's great @iguananaut but for a team it would require every member of the team to install it.
iguananaut commentedon Dec 2, 2013
@snopoke Yeah, it's still a shortcoming. The project that motivated me to do this would require probably at least 10 people to use it regularly. I think I can get them to install it without too much hassle but it still mystifies me that GH doesn't just implement this...
patcon commentedon Dec 2, 2013
@snopoke Maybe we could start a project that aggregates all the choice userscripts dealing with concerns in this repo into a one-click install userscript bundle? Might be nice to start having a focus for actionable items in this repo :)
cc: @isaacs
patcon commentedon Dec 2, 2013
Also, @isaacs, a tag or this sort of fix might be nice, for anyone wondering which issues have been fixed by the community. Maybe
fixed-workaroundorfixed-userscriptor something?eddieajau commentedon Dec 18, 2013
👍 @iguananaut - works like a charm
patcon commentedon Jan 28, 2014
This seems to be fixed after the redesign:
https://github.com/blog/1767-redesigned-conversations
@isaacs I think this can be closed :)
tjfontaine commentedon Jan 28, 2014
thanks @patcon for the notification and @github for fixing this
embray commentedon Jan 29, 2014
Well this sure is a thing that seems to have just happened. 👍 thanks @github