You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 18, 2021. It is now read-only.
Repository navigation
This repository was archived by the owner on Nov 18, 2021. It is now read-only.
It can be necessary to pick a different target branch for a pull request if you accidentally select the wrong one, or perhaps you're asked to rebase the branch against a development branch vs a stable branch.
Reacted by Cam Saul, Jayden, Scotty Vernon, Jan Voráček, Oleksii Kolotylenko, Adolfo Ochagavía, Oskar Stark, Evan Rutledge Borden, Ignacio Romero Zurbuchen, Pat Slocom and 28 more
What's wrong with closing and opening a new pull request? You can still reference the previous one if the discussion is of any value.
Reacted by Benedikt Roth
Reacted by TPS, Cam Saul, xeolabs, Kenny Tran, Colin Richardson, Nathan, Scotty Vernon, Jan Voráček, Dan Phung, Wilker Lúcio and 63 more
Reacted by TPS, Kenny Tran, Scotty Vernon, Jan Voráček, Michal Kawalec, Adolfo Ochagavía, Ignacio Romero Zurbuchen, Zilvinas Kucinskas, Ernesto García, alatyshau and 10 more
@jzaefferer There's nothing wrong with it. It's simply inconvenient.
Reacted by Mark Mikofski, Jeongseok (JS) Lee, Cam Saul, xeolabs, Ricardo N Feliciano, Jan Voráček, Matt Kanninen, Adolfo Ochagavía, Sullivan S., Evan Rutledge Borden and 41 more
It's also very tedious, and having to open a second because the goal post has changed for a milestone seems inconvenient, especially since I can rebase the target multiple times but in the end all utility of the comparison is lost because it's not pointing to anything sane
Reacted by TPS, Cam Saul, Jan Voráček, Matt Kanninen, Adolfo Ochagavía, Evan Rutledge Borden, George, Leagsaidh Gordon, alatyshau, Mykola and 3 more
It would also be handy if you could set the pull request target to a new branch. github could create a "pending branch" on upstream's repo. When the pull is merged, it creates - and immediately pushes to - the upstream branch.
Reacted by TPS, Matt King, Cam Saul, rafa, Jan Voráček, Adolfo Ochagavía, Evan Rutledge Borden, alatyshau, Robert (Jamie) Munro, Nicolas Granger and 3 more
Wow I thought I had time to waste...
So I put a thumbs up on the initial post but I spose the self posted +1s are working if people are getting irritated.
Reacted by Chuck, Matt Kanninen, Vasily Rodin, Paul Poulsen, TPS, tengwar, Trung Le, Jimmy Wärting and Anton Vynogradenko
Reacted by Chuck, David Alpert, Matt Kanninen, Vasily Rodin, Paul Poulsen, tengwar and Jimmy Wärting
Reacted by César Del Solar, Robert Korulczyk, Steven E. Harris, Kyle Gann, Rob Garrison, Phil Wells, Chuck, David Alpert, Norbert Melzer, Matt Kanninen and 18 more
Reacted by Alvin Crespo, Caleb Albritton, Chuck, Jordan Harband, David Alpert, Norbert Melzer, Matt Kanninen, Vasily Rodin, Paul Poulsen and Jimmy Wärting
Reacted by TPS, tengwar, Trung Le, jakirkham, Jimmy Wärting and Giacomo Lawrance
Reacted by S Devaney
Reacted by TPS, Cédric Dollinger, Ajax Manohar, andersondo, Fernando Correia, Ryan Leach, Michael Gamba, Bono de Visser, Trung Le, jakirkham and 2 more
I motion for the original comment to be edited with the update of implementation so this "thread" can be forever buried. Sorry to the hundreds of people who just got this email.
On Thu, Feb 16, 2017 at 8:10 AM Tom Johnell ***@***.***> wrote:
I motion for the original comment to be edited with the update of
implementation so this "thread" can be forever buried. Sorry to the
hundreds of people who just got this email.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#18 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAjuZrIrUEINNEM11kZHX1WBZlVkquWSks5rdHT7gaJpZM4AtTCy>
.
Repository owner locked and limited conversation to collaborators on Feb 16, 2017
Activity
thedrow commentedon Jun 5, 2013
Oh this is much needed 👍
jzaefferer commentedon Jun 11, 2013
What's wrong with closing and opening a new pull request? You can still reference the previous one if the discussion is of any value.
thedrow commentedon Jun 11, 2013
@jzaefferer There's nothing wrong with it. It's simply inconvenient.
tjfontaine commentedon Jun 11, 2013
It's also very tedious, and having to open a second because the goal post has changed for a milestone seems inconvenient, especially since I can rebase the target multiple times but in the end all utility of the comparison is lost because it's not pointing to anything sane
piedar commentedon Jun 21, 2013
I too would appreciate this feature.
It would also be handy if you could set the pull request target to a new branch. github could create a "pending branch" on upstream's repo. When the pull is merged, it creates - and immediately pushes to - the upstream branch.
servant-42 commentedon Jul 1, 2013
amirnissim commentedon Aug 6, 2013
bc-ben-buchanan commentedon Aug 13, 2013
delliott90 commentedon Aug 19, 2013
anton-rudeshko commentedon Aug 27, 2013
kuanxu commentedon Aug 29, 2013
reinert commentedon Aug 30, 2013
odedniv commentedon Aug 31, 2013
sjaeckel commentedon Sep 3, 2013
jaen commentedon Sep 3, 2013
Also in favour.
Just did a pull request to wrong branch and ended up with the longest diff.
1493 remaining items
TPS commentedon Aug 9, 2016
(@claydonkey #18 (comment) & #18 (comment))
claydonkey commentedon Aug 9, 2016
Wow I thought I had time to waste...
So I put a thumbs up on the initial post but I spose the self posted +1s are working if people are getting irritated.
btamayo commentedon Aug 15, 2016
Woo!
https://github.com/blog/2224-change-the-base-branch-of-a-pull-request
domino14 commentedon Aug 15, 2016
Finally! May this be the last comment on this thread.
TPS commentedon Aug 16, 2016
@tjfontaine (OP) @cirosantilli @ALL I hope that https://github.com/blog/2224-change-the-base-branch-of-a-pull-request (from #18 (comment)) means that this can be closed FTW. Else, could someone post what's missing?
(Sorry, @domino14. 😉)
beldaGR commentedon Aug 24, 2016
I experienced this problem: #750
Changed base branch but Github's visual diff did not change. After merging, previously reverted commits show up.
XedinUnknown commentedon Dec 1, 2016
How about giving admins the ability to change the target of a PR that someone else created?
JimLiu commentedon Jan 12, 2017
Is this the most commented issue on Github?
biolau commentedon Feb 16, 2017
Competitors have it just add it please!!!
+1
rhutchison commentedon Feb 16, 2017
@biolau it's implemented
@cirosantilli added the implemented label on Aug 16, 2016tjohnell-handy commentedon Feb 16, 2017
I motion for the original comment to be edited with the update of implementation so this "thread" can be forever buried. Sorry to the hundreds of people who just got this email.
domino14 commentedon Feb 16, 2017