You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 18, 2021. It is now read-only.
Repository navigation
This repository was archived by the owner on Nov 18, 2021. It is now read-only.
Web UI display wrong PR status in case 'approve' status was change to 'inapproved' #2008
I think this depends on your branch settings: do you require a minimum amount of approvals? It does show "4 pending reviewers", presumably one of them is the self-request. But you also already have 2 approvals, which may be enough to merge.
Hm, I see what you're saying, but it actually looks like it's consistent: Sanjeevani19 approved, so that counts as an approval, then self-requested another review. What happens then is GitHub notes that they want to review it again, but doesn't remove the old approval. That's why "2 approvals" remains, and the top notes that they are due for another review. That's also why you see a yellow dot by their name on top instead of a green check on top, but both the top and the bottom agree that there are "4 pending reviewers". (Notice how the bottom shows 2 approvals + 4 pending = 6 total, but the top only shows 5)
Activity
Levi-Lesches commentedon Jul 2, 2021
I think this depends on your branch settings: do you require a minimum amount of approvals? It does show "4 pending reviewers", presumably one of them is the self-request. But you also already have 2 approvals, which may be enough to merge.
Levi-Lesches commentedon Jul 4, 2021
Hm, I see what you're saying, but it actually looks like it's consistent: Sanjeevani19 approved, so that counts as an approval, then self-requested another review. What happens then is GitHub notes that they want to review it again, but doesn't remove the old approval. That's why "2 approvals" remains, and the top notes that they are due for another review. That's also why you see a yellow dot by their name on top instead of a green check on top, but both the top and the bottom agree that there are "4 pending reviewers". (Notice how the bottom shows 2 approvals + 4 pending = 6 total, but the top only shows 5)