Skip to content
This repository was archived by the owner on Nov 18, 2021. It is now read-only.
This repository was archived by the owner on Nov 18, 2021. It is now read-only.

Gist comments and mentions don't trigger notifications #21

Closed

Description

@max-mapper

this used to work.

to reproduce:

  • make a gist
  • have someone leave a command or @ mention you
  • you won't receive any emails

Activity

  1. luk- commented on Jun 5, 2013

    @luk-
  2. kastiglione commented on Jul 3, 2013

    @kastiglione

    I asked support about this, and on May 31st they said:

    Notifications for gist comments isn't implemented now, but it's something the team has discussed, so this could change in the future. We'll definitely announce this on our blog if it gets pushed out.

  3. balupton commented on Sep 20, 2013

    @balupton

    👍 it is soooooooo infuriating, it is a common occurrence where I discover a very important comment or even a job offer that is a year old or so on a gist

  4. balupton commented on Sep 20, 2013

    @balupton

    If anyone has any 3rd party solutions to this, then do please post!

  5. commonsguy commented on Oct 2, 2013

    @commonsguy

    And, according to this gist, this is a fairly popular feature request/bug fix. What is the point of having comments if the developer of the gist will not hear them (short of manually monitoring the page)? After all, we cannot use existing tools for change detection, partially because the page always changes ("Created NNN days ago") and partially because robots.txt blocks monitoring of gists.

  6. swrobel commented on Oct 11, 2013

    @swrobel
  7. r-a-y commented on Oct 20, 2013

    @r-a-y

    👍

  8. eddieajau commented on Oct 21, 2013

    @eddieajau

    👍 - very annoying

  9. BrainCrumbz commented on Oct 30, 2013

    @BrainCrumbz
  10. pstadler commented on Oct 31, 2013

    @pstadler

    +1

  11. X4 commented on Nov 5, 2013

    @X4

    👍
    I really need it too, but don't immediately send the notification and don't include the message in the notification!
    Every edit should increase the notification by 15minutes.

  12. patcon commented on Nov 5, 2013

    @patcon

    @X4 that sounds like i might be a separate issue request that's great in its own right..? re: delaying notifications using some known criteria.

    Would it be cool to open another issue on that?

  13. X4 commented on Nov 6, 2013

    @X4

    @patcon hmm, I believe that it's not required, because the changes would be both very simple and results in extending the function responsible for writing a notification flag that makes the notification icon on the top left shine. I assume GitHub uses some kind of asynchronous message passing system, so delaying a notification due to an edit under 15min would just require an update of the timestamp in the message queue.
    For efficiency reasons, I would not set it to a fixed time of 15minutes, but let it be larger, when required, so that more queued items can be updated at once. This would result in less updates.

  14. patcon commented on Nov 6, 2013

    @patcon

    Sorry, wasn't saying it wasn't simple, but just that it's not what the OP was asking about, and that it would definitely be useful for other things (as opposed to just gist comments) :)

  15. mehulkar commented on Nov 19, 2013

    @mehulkar
  16. 346 remaining items

  17. BenMorel commented on May 8, 2019

    @BenMorel

    Thank you Becca, will this be retroactive, i.e. will I get subscribed to all of my existing gists soon, or only to my new gists?

  18. Scrxtchy commented on May 8, 2019

    @Scrxtchy

    It sounds like it will take some time, there are probably tens of millions of gists to process through

  19. Logerfo commented on May 8, 2019

    @Logerfo

    From now on, you already get automatically subscribed to new gists you create, go ahead and try. The team will make the retroactive transition soon enough.

  20. BenMorel commented on May 8, 2019

    @BenMorel

    Indeed, I'm automatically subscribed to new gists. I'll wait a bit before looping through my gists and clicking Subscribe on each of them, then 👍

    (or before I finish writing this comment, someone in this thread will have written a script to do this automatically 😁 )

  21. becca commented on May 8, 2019

    @becca

    @oliveratgithub we'll update the product documentation 👍

    @BenMorel right now it's only new gists. we're going to work on the backfill to make it easier to be subscribed to gists you have authored from the past. i'll let you know when this lands but as @Scrxtchy mentioned it's a bit of a transition 😅 ...either way, we're on it!

  22. BigglesZX commented on May 8, 2019

    @BigglesZX

    @becca Amazing work, thank you! 👏

  23. dandv commented on May 8, 2019

    @dandv

    One giant step for Gist! But wait, this hasn't happened yet but will happen 4 hours from now!?

    image

    (my time has been set correctly for months, I haven't moved, not using a VPN etc.)

  24. usmonster commented on May 8, 2019

    @usmonster

    @dandv wrote:

    One giant step for Gist! But wait, this hasn't happened yet but will happen 4 hours from now!?

    image

    (my time has been set correctly for months, I haven't moved, not using a VPN etc.)

    #1576

  25. JMichaelTX commented on May 8, 2019

    @JMichaelTX

    @becca and the entire GitHub team: Thank you very much for implementing this long needed feature! 👍

    I can confirm that Gist notifications are now working, provided that you first subscribe to your own Gist.
    I understand that eventually GitHub will auto-subscribe the owner to all of his/her Gists, but for now you much manually subscribe to those Gists for which you want to receive notifications.

    I received email notification within a few (2-5) minutes of when the comment was made.

  26. JMichaelTX commented on May 8, 2019

    @JMichaelTX
  27. JMichaelTX commented on May 8, 2019

    @JMichaelTX

    I can confirm email notifications are now working.

  28. becca commented on Jun 3, 2019

    @becca

    👋just a quick update that we have been working on subscribing authors to their own previously authored gists (so you don't have to find and manually subscribe to each). this transition is now done! https://github.blog/changelog/2019-06-03-authors-subscribed-to-gists/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions