Skip to content
This repository was archived by the owner on Nov 18, 2021. It is now read-only.
This repository was archived by the owner on Nov 18, 2021. It is now read-only.

UI to promote issue to PR #93

Open

Description

@chadwhitacre

There's an API for converting an issue into a pull request. This is exposed in hub's pull-request subcommand. It would be aaaaawwwwweeeesssoooommmmeeee to have a web UI for this.

This is my personal number one feature request, hands down.

Activity

  1. chadwhitacre commented on Sep 6, 2013

    @chadwhitacre
    CollaboratorAuthor

    Here's the command I used to get the API to work for badges/shields#57:

    curl https://api.github.com/repos/gittip/shields.io/pulls \
        -u $PERSONAL_API_TOKEN: \
        -X POST \
        -d'{"issue": "57", "head": "collapse-path-parts", "base": "master"}'
    

    Here's some documentation for personal API tokens.

  2. chadwhitacre commented on Sep 6, 2013

    @chadwhitacre
    CollaboratorAuthor

    I sent an email to support@github.com about this.

  3. patcon commented on Sep 6, 2013

    @patcon

    Here's a workaround for now:
    http://issue2pr.herokuapp.com/

    Helpful to put it in your contributing.md

  4. chadwhitacre commented on Sep 7, 2013

    @chadwhitacre
    CollaboratorAuthor

    @patcon I had trouble with that today, due to the new two-factor auth implementation.

  5. chadwhitacre commented on Sep 7, 2013

    @chadwhitacre
    CollaboratorAuthor

    @mtodd:

    Hey Chad,

    Thanks for sharing your feature request! We appreciate the feedback.

    At GitHub, we prefer creating separate pull requests and then cross referencing the issue that it addresses. In the past, we've encountered problems when issues were turned into pull requests.

    One simple example is when the pull request turns out to be the wrong solution and another pull request is more appropriate. In that case, it makes more sense for two separate pulls to both refer to the original issue.

    Another example is when an issue's scope is bigger than just one pull request. In this case, several pulls can be created that refer back to the issue which each address different aspects of the overall issue.

    Again, thanks for sharing. This has been on our minds and is something we're hoping to address in the future!

    Cheers,
    Matt

  6. patcon commented on Sep 7, 2013

    @patcon

    Hm. That's unfortunate. Seems rather overbearing if that's the official rationale :/

    EDIT: When you submit emails, do you also link to the issue that you've created in this repo?

  7. chadwhitacre commented on Sep 10, 2013

    @chadwhitacre
    CollaboratorAuthor

    I couldn't get this working in hub (auth probs?) so I hacked this script: PRomote.sh.

  8. patcon commented on Sep 10, 2013

    @patcon

    Nice. FYI, hub --noop pull-request really helps debug when you're just getting used to using it.

    Also, might be relevant: mislav/hub#399

    Lastly, here's the format for the config file if you want to create it manually:

    ➜  drupal-monitoring git:(master) ✗ cat ~/.config/hub
    --- 
    github.com: 
    - oauth_token: xxxxxxxxxxxxxxxxxxxxxxx
      user: patcon
  9. patcon commented on Sep 10, 2013

    @patcon

    Oh hey, in case anyone missed it, there's talk of a make-do solution here:

    steveklabnik/issue2pr#5

  10. zbynekwinkler commented on Sep 21, 2013

    @zbynekwinkler
  11. chadwhitacre commented on Dec 11, 2013

    @chadwhitacre
    CollaboratorAuthor

    I don't want this anymore. Do I close this ticket or leave it open for others who do?

  12. patcon commented on Dec 11, 2013

    @patcon

    I've seen the sentiment elsewhere. Maybe leave it open?

  13. patcon commented on Jan 10, 2014

    @patcon

    This is a huge bummer, but it looks like github is discussing whether to deprecate the issue->PR feature :/

    mislav/hub@d6b7e1b

  14. rlidwka commented on Jan 14, 2014

    @rlidwka

    Oh gosh, why am I finding out features only when they're about to be removed? :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions