Skip to content
This repository was archived by the owner on Feb 5, 2024. It is now read-only.

Use the same chat buffer if it already exists#24

Closed
rguruprakash wants to merge 7 commits into
jellydn:mainfrom
rguruprakash:main
Closed

Use the same chat buffer if it already exists#24
rguruprakash wants to merge 7 commits into
jellydn:mainfrom
rguruprakash:main

Conversation

@rguruprakash

Copy link
Copy Markdown

Closes #23

WHAT

Use the same chat buffer if it already exists

WHY

Opening a new split/buffer for a chat when the existing chat buffer is not in focus is a bit uncomfortable to work with.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Linter
  • Tests
  • Review comments
  • Security

Guruprakash Rajakkannu and others added 3 commits January 26, 2024 18:49
@changeset-bot

changeset-bot Bot commented Jan 26, 2024

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: e1b7bcb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jellydn jellydn reopened this Feb 1, 2024
@jellydn

jellydn commented Feb 1, 2024

Copy link
Copy Markdown
Owner

Hi @rguruprakash Somehow, I didn't see your PR. Is that ready? Could you sync with main branch and let me know? Thanks.

@jellydn
jellydn marked this pull request as ready for review February 1, 2024 02:47
@jellydn
jellydn marked this pull request as draft February 1, 2024 15:24
@jellydn

jellydn commented Feb 1, 2024

Copy link
Copy Markdown
Owner

I have tested this approach but it is not working properly so I changed to draft.

@jellydn

jellydn commented Feb 2, 2024

Copy link
Copy Markdown
Owner

@all-contributors please add @rguruprakash for code

@allcontributors

Copy link
Copy Markdown

@jellydn

I've put up a pull request to add @rguruprakash! 🎉

jellydn added a commit that referenced this pull request Feb 5, 2024
* Fix Python 3.10 and add disable_extra_info option (#60)

* fix Python3.10 by removing Unpack type infomation

* add option to remove extra information: disable_extra_info

* chore(main): release 1.2.1 (#61)

* chore(doc): auto generate docs

* refactor!: disable extra info as default

* docs: add disable_extra_info flag on readme

* chore(doc): auto generate docs

* docs: add PostCyberPunk as a contributor for doc (#63)

* chore(doc): auto generate docs

* docs: add same keybinds in both visual and normal mode (#62) (#64)

Co-authored-by: PostCyberPunk <134976996+PostCyberPunk@users.noreply.github.com>

* chore(doc): auto generate docs

---------

Co-authored-by: gptlang <121417512+gptlang@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Co-authored-by: PostCyberPunk <134976996+PostCyberPunk@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proposal to use same buffer instead of creating new ones when chat buffer is not focused

2 participants