Repository navigation
Reconciler needs to provide a filter function for leader election #1891
Description
Expected Behavior
Tekton has created a new custom resource called Run for running custom tasks. Each custom task implementer will provide a reconciler that watches for and processes Run objects that refer to its kind of custom task, through the use of the filter function given to the run informer.
Actual Behavior
We've found a case where a reconciler is given all Run objects, not just the ones it has requested through the filter function given to the run informer. This happens during leader election in this code:
A custom task implementer will not want to be given Run objects that it isn't written to handle. It needs to be able to pass a filter function to filter the objects on this path.
Steps to Reproduce the Problem
Any controller using leader election goes through this path. Run objects may be the first case though where there may be multiple independent controllers that are only interested in distinct subsets of the objects.
Activity
GregDritschler commentedon Nov 3, 2020
@n3wscott fyi
n3wscott commentedon Nov 3, 2020
Thanks for the bug report, I think we can fix this quick, but it will need to be in a few days because of the current release.
github-actions commentedon Feb 2, 2021
This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with
/reopen. Mark the issue asfresh by adding the comment
/remove-lifecycle stale.slinkydeveloper commentedon Feb 2, 2021
/remove-lifecycle-stale
Hitting this issue while developing a secrets reconciler
slinkydeveloper commentedon Feb 2, 2021
My controller loops indefinitely trying to reconcile every secret in the cluster, although I've set the following filters: https://github.com/slinkydeveloper/control-data-plane-communication/pull/11/files#diff-758961aac53d57d417fc85fa07093ab347dbd01929ebfc54ffe0cf2af64675b6R77
github-actions commentedon May 5, 2021
This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with
/reopen. Mark the issue asfresh by adding the comment
/remove-lifecycle stale.slinkydeveloper commentedon May 5, 2021
/remove-lifecycle stale
github-actions commentedon Aug 5, 2021
This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with
/reopen. Mark the issue asfresh by adding the comment
/remove-lifecycle stale.dprotaso commentedon Sep 17, 2021
/reopen
/lifecycle frozen