Skip to content

Class-based reconcilers can't be hosted in one binary with HA #2109

New issue
New issue
Open
Open
Class-based reconcilers can't be hosted in one binary with HA#2109
Labels
kind/bugCategorizes issue or PR as related to a bug.lifecycle/frozenIndicates that an issue or PR should not be auto-closed due to staleness.

Description

@markusthoemmes
markusthoemmes
opened on Apr 29, 2021

/kind bug

Expected Behavior

I can host as many class-based controllers (for example: Ingress reconcilers) as I want in a binary, as long as the classes don't clash.

Actual Behavior

They try to get the same lease and thus only one really works. This is quite similar to #1979.

Steps to Reproduce the Problem

  1. Create a binary that launches two Ingress reconcilers
  2. Launch it and see how it competes for the lease.

Additional Info

This is quite similar to #1979.

I guess the simplest way of fixing it is adding the class filter to the lease name.

Activity

  1. knative-prow-robot
    added
    kind/bugCategorizes issue or PR as related to a bug.
    on Apr 29, 2021

  2. github-actions commented on Jul 29, 2021

    @github-actions
    github-actionsBot
    on Jul 29, 2021
    Contributor

    This issue is stale because it has been open for 90 days with no
    activity. It will automatically close after 30 more days of
    inactivity. Reopen the issue with /reopen. Mark the issue as
    fresh by adding the comment /remove-lifecycle stale.

  3. github-actions
    added
    lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale.
    on Jul 29, 2021

  4. markusthoemmes commented on Jul 29, 2021

    @markusthoemmes
    markusthoemmes
    on Jul 29, 2021
    ContributorAuthor

    /lifecycle frozen

  5. knative-prow-robot
    added
    lifecycle/frozenIndicates that an issue or PR should not be auto-closed due to staleness.
    and removed
    lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale.
    on Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/bugCategorizes issue or PR as related to a bug.lifecycle/frozenIndicates that an issue or PR should not be auto-closed due to staleness.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions