You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Add warning for Source.spec.ceOverride.extension names that are longer than 20 characters and with uppercase letters #2258
Problem
As stated on the Cloud Events Spec
the attribute naming convention suggest (SHOULD, not MUST) that the names are no longer than 20 characters. We should add at maybe a warning for that cases, even when this does not imply an error. Also, when there are keys with upper case letters there could be a collision (cause the keys get converted to lower-case), in that keys the value corresponds with the last defined key (generally)
Exit Criteria
When you set an extension name longer than 20 characters on any source.spec.ceOverride.extensions extension, the logs show a warning about that extension name
Additional context (optional) Here should be any warning or validation related to sources 😉
changed the title [-]Add warning for Source.spec.ceOverride.extension names that are longer than 20 characters[/-][+]Add warning for Source.spec.ceOverride.extension names that are longer than 20 characters and with collision names[/+]on Sep 3, 2021
changed the title [-]Add warning for Source.spec.ceOverride.extension names that are longer than 20 characters and with collision names[/-][+]Add warning for Source.spec.ceOverride.extension names that are longer than 20 characters and with uppercase letters[/+]on Sep 3, 2021
This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Activity
[-]Add warning for Source.spec.ceOverride.extension names that are longer than 20 characters[/-][+]Add warning for Source.spec.ceOverride.extension names that are longer than 20 characters and with collision names[/+][-]Add warning for Source.spec.ceOverride.extension names that are longer than 20 characters and with collision names[/-][+]Add warning for Source.spec.ceOverride.extension names that are longer than 20 characters and with uppercase letters[/+]github-actions commentedon Dec 3, 2021
This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with
/reopen. Mark the issue asfresh by adding the comment
/remove-lifecycle stale.pierDipi commentedon Jan 3, 2022
/remove-lifecycle stale
/triage accepted
/reopen
knative-prow-robot commentedon Jan 3, 2022
@pierDipi: Reopened this issue.
Details
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
anjalii-28 commentedon Jan 13, 2026
Hi maintainers, I’m interested in working on this.
Before starting, can you confirm this warning behavior is still desired
and where you’d prefer it to live (validation webhook vs controller)?
dprotaso commentedon Jan 19, 2026
cc @creydr @Cali0707 for input