Skip to content

Add warning for Source.spec.ceOverride.extension names that are longer than 20 characters and with uppercase letters #2258

Open

Description

@gabo1208

Problem
As stated on the Cloud Events Spec
the attribute naming convention suggest (SHOULD, not MUST) that the names are no longer than 20 characters. We should add at maybe a warning for that cases, even when this does not imply an error. Also, when there are keys with upper case letters there could be a collision (cause the keys get converted to lower-case), in that keys the value corresponds with the last defined key (generally)

Persona:
Producers, consumers and integrators

Exit Criteria
When you set an extension name longer than 20 characters on any source.spec.ceOverride.extensions extension, the logs show a warning about that extension name

Additional context (optional)
Here should be any warning or validation related to sources 😉

Activity

  1. changed the title [-]Add warning for Source.spec.ceOverride.extension names that are longer than 20 characters[/-] [+]Add warning for Source.spec.ceOverride.extension names that are longer than 20 characters and with collision names[/+] on Sep 3, 2021
  2. changed the title [-]Add warning for Source.spec.ceOverride.extension names that are longer than 20 characters and with collision names[/-] [+]Add warning for Source.spec.ceOverride.extension names that are longer than 20 characters and with uppercase letters[/+] on Sep 3, 2021
  3. github-actions commented on Dec 3, 2021

    @github-actions
    Contributor

    This issue is stale because it has been open for 90 days with no
    activity. It will automatically close after 30 more days of
    inactivity. Reopen the issue with /reopen. Mark the issue as
    fresh by adding the comment /remove-lifecycle stale.

  4. added
    lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale.
    on Dec 3, 2021
  5. pierDipi commented on Jan 3, 2022

    @pierDipi
    Contributor

    /remove-lifecycle stale
    /triage accepted
    /reopen

  6. knative-prow-robot commented on Jan 3, 2022

    @knative-prow-robot
    Contributor

    @pierDipi: Reopened this issue.

    Details

    In response to this:

    /remove-lifecycle stale
    /triage accepted
    /reopen

    Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

  7. removed
    lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale.
    on Jan 3, 2022
  8. anjalii-28 commented on Jan 13, 2026

    @anjalii-28
    Contributor

    Hi maintainers, I’m interested in working on this.

    Before starting, can you confirm this warning behavior is still desired
    and where you’d prefer it to live (validation webhook vs controller)?

  9. dprotaso commented on Jan 19, 2026

    @dprotaso
    Member

    cc @creydr @Cali0707 for input

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    triage/acceptedIssues which should be fixed (post-triage)

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions